[ML] Always use Boost unordered maps/sets #1647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The memory instrumentation in core::CMemory exists for boost::unordered_set and boost::unordered_map, but not the std equivalents. It is better that we switch all uses in the codebase at the same time (or even switch to completely different hash container implementations). This change switches the few cases of std::unordered_map and std::unordered_set to the boost versions. This may cause some increases in reported memory usage, where these containers are in memory instrumented classes. It won't increase actual memory usage (at least not significantly), just make the reporting more accurate.
droberts195
added a commit
to droberts195/ml-cpp
that referenced
this pull request
Jan 11, 2021
The memory instrumentation in core::CMemory exists for boost::unordered_set and boost::unordered_map, but not the std equivalents. It is better that we switch all uses in the codebase at the same time (or even switch to completely different hash container implementations). This change switches the few cases of std::unordered_map and std::unordered_set to the boost versions. This may cause some increases in reported memory usage, where these containers are in memory instrumented classes. It won't increase actual memory usage (at least not significantly), just make the reporting more accurate. Backport of elastic#1647
droberts195
added a commit
that referenced
this pull request
Jan 11, 2021
The memory instrumentation in core::CMemory exists for boost::unordered_set and boost::unordered_map, but not the std equivalents. It is better that we switch all uses in the codebase at the same time (or even switch to completely different hash container implementations). This change switches the few cases of std::unordered_map and std::unordered_set to the boost versions. This may cause some increases in reported memory usage, where these containers are in memory instrumented classes. It won't increase actual memory usage (at least not significantly), just make the reporting more accurate. Backport of #1647
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The memory instrumentation in core::CMemory exists for
boost::unordered_set and boost::unordered_map, but not
the std equivalents. It is better that we switch all
uses in the codebase at the same time (or even switch
to completely different hash container implementations).
This change switches the few cases of std::unordered_map
and std::unordered_set to the boost versions. This may
cause some increases in reported memory usage, where these
containers are in memory instrumented classes. It won't
increase actual memory usage (at least not significantly),
just make the reporting more accurate.