[ML] Amalgamate addArrival methods #1536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provide a common interface to addArrival by extending the existing SMessage structure.
edsavage
added a commit
to edsavage/ml-cpp
that referenced
this pull request
Oct 15, 2020
Provide a common interface to addArrival by extending the existing SMessage structure. Relates to elastic#1477
edsavage
added a commit
that referenced
this pull request
Oct 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide a common interface to addArrival by extending the existing SMessage structure.
This reduces the amount of code duplicated between multiple addArrival methods at the expense of some added verbosity when specifying default arguments.
Relates to #1477