[ML] Replace boost::size in model unit tests #1517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use modern C++ data structures, initialisation to remove the need for boost::size. Use uniform braced initialisation of variables consistently.
droberts195
approved these changes
Sep 30, 2020
| using TStrSizePrVec = std::vector<TStrSizePr>; | ||
| using TStrSizePrVecVec = std::vector<TStrSizePrVec>; | ||
| using TStrSizePrVecVecVec = std::vector<TStrSizePrVecVec>; | ||
| using TStrUInt64Map = std::map<std::string, uint64_t>; |
There was a problem hiding this comment.
It would still be good to work towards having all these types as public members of the test fixture rather than in the global namespace, but it can wait for a subsequent PR in the series.
edsavage
added a commit
to edsavage/ml-cpp
that referenced
this pull request
Sep 30, 2020
Use modern C++ data structures, initialisation to remove the need for boost::size. Use uniform braced initialisation of variables consistently.
edsavage
added a commit
that referenced
this pull request
Sep 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use modern C++ data structures, initialisation to remove the need for
boost::size.
Use uniform braced initialisation of variables consistently.
Relates to #1477