-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Prefer smaller models with similar performance #1516
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valeriy42
changed the title
[WIP][ML] Prefer smaller models with similar performance
[ML] Prefer smaller models with similar performance
Oct 13, 2020
@wwang500 just a heads-up: in some cases this may lead to a regression of the results by <1% (in terms of MSE, MSLE, Huber) or less (for classification). |
tveasey
approved these changes
Oct 13, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
valeriy42
added a commit
to valeriy42/ml-cpp
that referenced
this pull request
Oct 13, 2020
For regression and classification, during hyperparameter optimization we prefer smaller models if the loss functions are otherwise comparable. To this end, we add 0.01 * "forest number nodes" * E[GP] / "average forest number nodes" as an additional penalty.
valeriy42
added a commit
that referenced
this pull request
Oct 14, 2020
For regression and classification, during hyperparameter optimization we prefer smaller models if the loss functions are otherwise comparable. To this end, we add 0.01 * "forest number nodes" * E[GP] / "average forest number nodes" as an additional penalty. Backport of #1516.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For regression and classification, during hyperparameter optimization we prefer smaller models if the loss functions are otherwise comparable.
To this end, we add 0.01 * "forest number nodes" * E[GP] / "average forest number nodes" as an additional penalty.