Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Change outlier detection feature influence format to nested object #1475

Conversation

dimitris-athanasiou
Copy link
Contributor

This changes the format of feature_influence for outlier detection so
that the feature name is not part of the field name. This helps reduce
field explosion in the results index.

Feature influence is now an array with nested objects. Each of them contains
the feature_name and the influence value.

This changes the format of `feature_influence` for outlier detection so
that the feature name is not part of the field name. This helps reduce
field explosion in the results index.

Feature influence is now an array with nested objects. Each of them contains
the `feature_name` and the `influence` value.
Copy link
Contributor

@valeriy42 valeriy42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dimitris-athanasiou
Copy link
Contributor Author

retest

@dimitris-athanasiou dimitris-athanasiou merged commit 06cc5dc into elastic:master Sep 8, 2020
@dimitris-athanasiou dimitris-athanasiou deleted the change-outlier-detection-feature-influence-format-to-nested branch September 8, 2020 16:37
dimitris-athanasiou added a commit to dimitris-athanasiou/ml-cpp that referenced this pull request Sep 8, 2020
… object (elastic#1475)

This changes the format of `feature_influence` for outlier detection so
that the feature name is not part of the field name. This helps reduce
field explosion in the results index.

Feature influence is now an array with nested objects. Each of them contains
the `feature_name` and the `influence` value.

Backport of elastic#1475
dimitris-athanasiou added a commit that referenced this pull request Sep 9, 2020
… object (#1475) (#1479)

This changes the format of `feature_influence` for outlier detection so
that the feature name is not part of the field name. This helps reduce
field explosion in the results index.

Feature influence is now an array with nested objects. Each of them contains
the `feature_name` and the `influence` value.

Backport of #1475
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants