-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Change outlier detection feature influence format to nested object #1475
Merged
dimitris-athanasiou
merged 4 commits into
elastic:master
from
dimitris-athanasiou:change-outlier-detection-feature-influence-format-to-nested
Sep 8, 2020
Merged
[ML] Change outlier detection feature influence format to nested object #1475
dimitris-athanasiou
merged 4 commits into
elastic:master
from
dimitris-athanasiou:change-outlier-detection-feature-influence-format-to-nested
Sep 8, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the format of `feature_influence` for outlier detection so that the feature name is not part of the field name. This helps reduce field explosion in the results index. Feature influence is now an array with nested objects. Each of them contains the `feature_name` and the `influence` value.
valeriy42
approved these changes
Sep 8, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
retest |
dimitris-athanasiou
deleted the
change-outlier-detection-feature-influence-format-to-nested
branch
September 8, 2020 16:37
dimitris-athanasiou
added a commit
to dimitris-athanasiou/ml-cpp
that referenced
this pull request
Sep 8, 2020
… object (elastic#1475) This changes the format of `feature_influence` for outlier detection so that the feature name is not part of the field name. This helps reduce field explosion in the results index. Feature influence is now an array with nested objects. Each of them contains the `feature_name` and the `influence` value. Backport of elastic#1475
dimitris-athanasiou
added a commit
that referenced
this pull request
Sep 9, 2020
… object (#1475) (#1479) This changes the format of `feature_influence` for outlier detection so that the feature name is not part of the field name. This helps reduce field explosion in the results index. Feature influence is now an array with nested objects. Each of them contains the `feature_name` and the `influence` value. Backport of #1475
61 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the format of
feature_influence
for outlier detection sothat the feature name is not part of the field name. This helps reduce
field explosion in the results index.
Feature influence is now an array with nested objects. Each of them contains
the
feature_name
and theinfluence
value.