Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Migrate from boost::math to std where possible #128

Closed
3 tasks
hendrikmuhs opened this issue Jun 14, 2018 · 0 comments · Fixed by #132
Closed
3 tasks

[ML] Migrate from boost::math to std where possible #128

hendrikmuhs opened this issue Jun 14, 2018 · 0 comments · Fixed by #132
Assignees
@hendrikmuhs
Labels
:ml >refactoring v6.4.0 v7.0.0

Comments

@hendrikmuhs
Copy link

Follow-up from #126

This is a meta-issue listing all possible re-factorings made possible by C++11 based on scanning the code at the time of writing this issue:

  • use CTools::lgamma (wrapper for std::lgamma)
  • isnan, isinf, isfinite
  • erf
@hendrikmuhs hendrikmuhs self-assigned this Jun 15, 2018
@hendrikmuhs hendrikmuhs mentioned this issue Jun 15, 2018
Merged
hendrikmuhs pushed a commit that referenced this issue Jun 20, 2018
[ML] Refactor code to use std::lgamma instead of boost::math::lgamma (#…
601f344 
…132)

Migrate remaining codebase to std::lgamma, std::{isfinite,isinf,isnan}andstd::erf`

fixes #128
hendrikmuhs pushed a commit to hendrikmuhs/ml-cpp that referenced this issue Jun 20, 2018
[ML] Refactor code to use std::lgamma instead of boost::math::lgamma (e…
8150c5f 
…lastic#132)

Migrate remaining codebase to std::lgamma, std::{isfinite,isinf,isnan}andstd::erf`

fixes elastic#128
hendrikmuhs pushed a commit that referenced this issue Jun 20, 2018
[ML] Refactor code to use std::lgamma instead of boost::math::lgamma (#…
e78785c 
…132)

Migrate remaining codebase to std::lgamma, std::{isfinite,isinf,isnan}andstd::erf`

fixes #128
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hendrikmuhs hendrikmuhs

Labels
:ml >refactoring v6.4.0 v7.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ML] Refactor code to use std::lgamma instead of boost::math::lgamma hendrikmuhs/ml-cpp
1 participant
@hendrikmuhs