-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#8442 Java Pipeline Compiler #8543
#8442 Java Pipeline Compiler #8543
Conversation
761b551
to
2e5a69f
Compare
2e5a69f
to
ba14481
Compare
62af843
to
2dacc98
Compare
@andrewvc FYI, this gives us very clean (imo) testing of stuff that requires Ruby code from JUnit + Gradle, just a one-off call now <= https://github.com/elastic/logstash/pull/8543/files#diff-c80ddff243fd1a3eb2407f3ccc53418bR22. Obviously, requires a few changes to the whole Gradle-Rake interaction. Though the only "not under the hood" change is that Not sure if we want to go Gradle all the way now? I don't think we should merge this thing, and mix test changes + build system changes, but we def. need a change like this to get a clean Gradle Either way, finally found a clean way to set this kind of thing up and getting something like this in would way speed up finishing up on the end-to-end codegen obviously :) |
297452b
to
6406405
Compare
@jakelandis maybe we could go over this one whenever you have some time (starting tomorrow, don't have much time today myself :)). I think with this kind of test (JUnit that heavily relies on Ruby code) on the horizon it may make sense to adjust the split between RSpec and JUnit run on CI (one option may be to abandon it altogether since the combined RSpec + JUnit run from #8517 is faster than an IT run anyhow right?). |
@original-brownbear - sure, I can assist with adjusting our testing as needed. However, I am bit hesitant to replace the 'pure' RSpec tests with the JUnit wrapper variant since the JUnit wrapper utilizes JRuby as a Java library as opposed to the implementation of Ruby. I don't want to get too far away from how the code is actually run. I am in favor of adding in an extra step for the combined execution, or simply adjusting the JUnit tests to use gradle task that also runs the Rspecs. (the latter shouldn't require any infra changes) |
+1 on this, the thing is, the whole discussion is tightly coupled to making the entry-point Java in #8161 , which itself would greatly benefit from heaving tests execute Java first (+ getting rid of the |
Closing here in favor of the less invasive #8569 |
Still WIP but 85% there:
Some notes for the time being:
rbx-stdlib
is not relevant anymore => removedgem
andbundler
to save some time :)./gradlew assemble bootstrap :ingest-converter:assemble
fromrake
is admittedly kind of dirt, but invoking the full cycleassemble
here would introduce an obvious circular dependency between Gradle and Rake ... so I opted for the shortcut here for a POC/Step1