handle fully acked zero byte page at queue open #7810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 25, 2017
|
The jenkins build failure is about DLQ which seems unrelated to this PR. |
|
I will have to trust the failing and then not failing test and Colin on this one. |
|
Second review? |
|
Build failures seem unrelated. LGTM |
jordansissel
approved these changes
Aug 1, 2017
|
Merging since Colin is on vacation. |
suyograo
pushed a commit
that referenced
this pull request
Aug 2, 2017
suyograo
pushed a commit
that referenced
this pull request
Aug 2, 2017
suyograo
pushed a commit
that referenced
this pull request
Aug 2, 2017
suyograo
pushed a commit
that referenced
this pull request
Aug 2, 2017
colinsurprenant
added a commit
that referenced
this pull request
Nov 30, 2017
colinsurprenant
added a commit
that referenced
this pull request
Nov 30, 2017
|
This PR commit was not merged into 5.6. I just correctly added it in 5.6 and will be part of 5.6.5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #7809
This fixes the condition upon opening the queue, a page file of zero byte with a fully acked checkpoint would generate this exception:
I also added a test to reproduce that problem. Without this fix the test fails with the above exception and passes with this PR.
This condition should not prevent LS from starting since fully acked page are simply purged in the open process. Here we just do the purge before checking on the file size.
Now, the condition which leads to having a zero byte page file is still unknown.
followup issue #7811 to DRY the code. This seems to be an acceptable fix for now.