Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

9k update #6713

Closed
wants to merge 7 commits into from
Closed

9k update #6713

wants to merge 7 commits into from

Conversation

guyboertje
Copy link
Contributor

No description provided.

@@ -1,6 +1,7 @@
namespace "vendor" do
VERSIONS = {
"jruby" => { "version" => "1.7.25", "sha1" => "cd15aef419f97cff274491e53fcfb8b88ec36785" },
"jruby" => { "version" => "9.1.6.0", "sha1" => "6dada28876caf2ac14de83dbb45d5243fbbd4940" },
# "jruby" => { "version" => "1.7.25", "sha1" => "cd15aef419f97cff274491e53fcfb8b88ec36785" },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove this all together?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure.

@suyograo
Copy link
Contributor

@guyboertje thanks! Can you take a look at the test failures on travis?

@guyboertje
Copy link
Contributor Author

@suyograo
I have been looking at the Travis fails. Initially I can't decide whether to modify the travis job itself as a fix or to expect that the travis job as is should run and that I must discover that which is preventing travis from running.

@guyboertje
Copy link
Contributor Author

The core specs pass but the integration specs are being hit with this travis "feature" travis-ci/travis-ci#6471

@ph
Copy link
Contributor

ph commented May 17, 2017

I will close this and start working on the feature branch instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants