Add docs for monitoring API changes in Alpha4 #5553
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| GET /_node/stats/pipeline | ||
| -------------------------------------------------- | ||
|
|
||
| //REVIEWERS: Note that when you call /_node/stats, it does not return the pipeline stats. You need to specify /_node/stats/pipeline specifically. This makes me wonder if it shouldn't be its own API topic. WDYT? |
There was a problem hiding this comment.
This is intentional. /_node/stats/pipeline is too verbose (customers have complex plugin configs) to be included in /_node/stats. Yes it should be a separate API topic.
There was a problem hiding this comment.
Fixed. Made this a separate topic called Pipeline Info API.
|
@dedemorton I added some comments |
dedemorton
force-pushed
the
logstash_issue#5475
branch
from
174e985 to
d9065d1
Compare
|
@suyograo I've made the changes that you suggested and retested the REST calls. Let me know if this is ready to merge. |
|
LGTM |
elasticsearch-bot
pushed a commit
that referenced
this pull request
Jun 28, 2016
elasticsearch-bot
pushed a commit
that referenced
this pull request
Jun 28, 2016
elasticsearch-bot
pushed a commit
that referenced
this pull request
Jun 28, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jordansissel @andrewvc @suyograo Not sure who needs to review this, but here you go! Please read and respond to the questions that I've added as comments flagged for REVIEWERS. There were a few places where the API calls didn't behave exactly as described in #5475.
This adds changes for monitoring APIs (tracked by doc issue #5148).