Bugfix from manual test of new plugin generator on master

[wiibaa]

Happy to be one of the first to test very sweet work by @purbon
Here are some minor corrections

• fix to allow direct execution of 'bundle install' => direct run of bundler was throwing an error due to unescaped single quote in gemspec
• make plugin name parameter required => forgetting the --name param resulted in a cryptic error "cannot call downcase() on Nil", now report that --name is mandatory
• display correct path of created files, the listing of created file did not contains subfolders (i.e lib/logstash/...)
• use new event api in generator filter template => bundle exec rspec was failing on master for filter plugin due to usage of old event api
• fix config_name for generated input plugin => typo in the template of the input for the config_name setting

[elasticsearch-release]

Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run; then say 'jenkins, test it'.

[suyograo]

nice catch @wiibaa. LGTM

[elasticsearch-bot]

Suyog Rao merged this into the following branches!

Branch	Commits
master	53c0bc1, 0665497, 9c4bac7, cd30aa9, f2cf643
5.0	464bdca, e2b5c87, dafe75d, 4f96f23, be9bac9

[wiibaa]

@suyograo @purbon can you please check and take care of backport to 2.x if needed ?

[purbon]

First, sorry for the bugs introduced and thanks a lot to spot them and fix
them. I appreciate.

Re backport, sure. Im on it.

/purbon

On Wed, 25 May 2016 00:07 Philippe Weber, [email protected] wrote:

@suyograo https://github.com/suyograo @purbon
https://github.com/purbon can you please check and take care of
backport to 2.x if needed ?

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#5355 (comment)