Feature/release packaging #5341
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
untergeek
force-pushed
the
feature/release_packaging
branch
from
9e3cc25 to
4bc2335
Compare
This was referenced May 22, 2016
| @@ -23,3 +23,6 @@ gem "rubyzip", "~> 1.1.7", :group => :build | |||
| gem "gems", "~> 0.8.3", :group => :build | |||
| gem "rack-test", :require => "rack/test", :group => :development | |||
| gem "flores", "~> 0.0.6", :group => :development | |||
| gem "pleaserun" | |||
| gem "mustache" | |||
There was a problem hiding this comment.
I don't see Mustache invoked in this PR. Pleaserun uses it, but lists it as a dependency. Do we need it listed here?
Same question for Clamp.
|
Tested new dir structure and its consistent with ES layout. LGTM. |
3 tasks
5 tasks
Update after-install scripts Use /usr/lib/logstash instead of /opt/logstash More revisions. Using `/usr/share/logstash` instead of `/usr/lib/logstash` Track these new files More work in progress. Proper arg parsing obtained WIP: Use jvm.options like ES Remove facter dependency Due to an update from @jordansissel on pleaserun, facter is no longer necessary Revert Gemfile to proper version Latest work in progress. I added a simple test to logstash.lib.sh to catch empty strings in java options. Added `startup.options`, and touched up `jvm.options` Edited the package scripts to make things play nice with new paths. Tweaked `system-install` to allow users to provide their own `startup.options` file. Patch up merge failure Changes to work with the new logstash.yml Add fpm dependency (build fails without it) Fix missing gems in Gemfile Don't know how these got lost Use /etc/logstash for configuration in packages Update the instructions/documentation for... ...startup.options Merging proposed changes Remove mustache and clamp They're covered by pleaserun anyway Prune config dir from /usr/share/logstash... ...but only when using RPM/DEB packages
untergeek
force-pushed
the
feature/release_packaging
branch
from
f99ed24 to
27117f9
Compare
|
Aaron Mildenstein merged this into the following branches!
|
|
Eeee much excite. |
This was referenced May 29, 2016
This was referenced May 31, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to work with @jsvd's work on
logstash.ymlsettings.This uses a wrapper around
pleaserun(bin/system-install) to generate the proper startup files for whatever environment you're using.