Add changes that support settings files #5332
Conversation
| If you find that events are backing up, or that the CPU is not saturated, consider increasing | ||
| this number to better utilize machine processing power. | ||
|
|
||
| *`--pipeline.output.workers COUNT`*:: |
There was a problem hiding this comment.
@suyograo or @jsvd I'm not convinced this is a valid CLI flag.
pipeline.output.workers DOES NOT exist here:
https://github.com/elastic/logstash/blob/master/logstash-core/lib/logstash/runner.rb
But it does exist here:
https://github.com/elastic/logstash/blob/master/config/logstash.yml#L34
There was a problem hiding this comment.
@jsvd did you mean workers in output plugins?
There was a problem hiding this comment.
@andrewvc should we expose pipeline.output.workers to the command line and make it known?
There was a problem hiding this comment.
IMHO, we should not. Its just inconsistent to have 1 config option being exposed this way. We should not set this precedent.
|
@dedemorton Can we also add a separate section "Using the Settings File" or something similar to call out the existence of Since this is new its good to push its visibility. |
| -w, --pipeline.workers COUNT | ||
| Sets the number of pipeline workers (threads) to run for filter processing (default: number of cores). | ||
| *`-w, --pipeline.workers COUNT`*:: | ||
| Sets the number of pipeline workers (threads) to run for filter processing (default: half the number of cores). |
There was a problem hiding this comment.
I mislead you here, @dedemorton, it's actually the number of cores, not half (set in here)
[edit] please fix also in config/logstash.yml
|
@suyograo Sure, I can add the info to a separate topic. I decided to err on the side of minimalism here, but I can see how having a separate topic might raise visibility that the file exists. |
dedemorton
force-pushed
the
logstash_issue#4401
branch
from
aa22440 to
519eee5
Compare
dedemorton
force-pushed
the
logstash_issue#4401
branch
from
519eee5 to
02342c2
Compare
|
LGTM |
1 similar comment
|
LGTM |
Adds doc about settings file to resolve an item listed in #5148
Summary of changes: