[WIP] Add doc for new monitoring API end points #5308
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -142,8 +248,11 @@ Example response: | |||
| { | |||
| "events": { | |||
| "in": 91, | |||
| "bytes_in": 900000 | |||
There was a problem hiding this comment.
this stat bytes_in, bytes_filtered and bytes_out will not make alpha3, so we should remove it
|
@dedemorton I won't be able to leave an LGTM till I close out #4923 Will leave a partial review today |
|
closing this because most of these changes did not get into alpha3. I will open a separate PR for alpha3 changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First draft of content to address doc changes for issue #4923. I need to test these additions when the code for the APIs is implemented.