[WIP] refactor Ruby Event getter and setter #5170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| gem "tins", "1.6", :group => :development | ||
| gem "rspec", "~> 3.1.0", :group => :development | ||
| gem "logstash-devutils", "~> 0.0.15", :group => :development | ||
| gem "logstash-devutils", ">= 0", :path => "/Users/colin/dev/src/elasticsearch/logstash-devutils" |
There was a problem hiding this comment.
yes, this is not a mergeable WIP and I added in the description that these must be addressed...
|
@colinsurprenant I think the following strategy will work:
I guess we need to bump major version of the plugin too? |
|
+1 to what @ph said. Also update the gemspec for all plugins |
|
@suyograo @colinsurprenant we should also be able to release the new plugins with their major version and test them. People wont be able to install them in version prior to < 5.0. |
|
+1 |
This was referenced Apr 27, 2016
colinsurprenant
force-pushed
the
feature/event_interface
branch
3 times, most recently
from
549869f to
16ef684
Compare
|
Test are passing, all the updated plugins are also passing. LGTM. |
|
ok, so will push commit to remove branches plugins gem, then we can merge in master |
|
rebasing and merging. |
refactor wip gemfiles refactor Java Event getter and setter bump plugin-api to 2.0 use plugin-api 2.0 switch to core-event-java include logstash-core-event-java.jar jar file so that gem dependency using the source tree work updated core plugins to core-api 2.0 added grok for refactor branch fix rebased specs remove temp plugins github paths remove commented out tmp alias_method
colinsurprenant
force-pushed
the
feature/event_interface
branch
from
a94fb4f to
ee2c8af
Compare
|
merged into master and 5.0 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a WIP for the Event getter and setter refactor.
Per #5141 and #5140
This code is pushed in
feature/event_interfaceshared branch.For this to work the plugins using a local
:pathin the included modifiedGemfileneed to be tweeked to use the new interface.