Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: remove breaking change tags #15231

Merged
merged 2 commits into from
Aug 1, 2023
Merged

doc: remove breaking change tags #15231

merged 2 commits into from
Aug 1, 2023

Conversation

jrodewig
Copy link
Contributor

@jrodewig jrodewig commented Aug 1, 2023

Release notes

[rn:skip]

What does this PR do?

Removes tags for notable breaking changes and related comments.

Why is it important/What is the impact to the user?

With elastic/stack-docs#2495 merged, we no longer need tags to reuse breaking changes in the Stack Install/Upgrade guide.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files (and/or docker env variables)
  • I have added tests that prove my fix is effective or that my feature works

Related issues

https://github.com/elastic/platform-docs-team/issues/143

@jrodewig jrodewig requested a review from karenzone August 1, 2023 19:41
@jrodewig jrodewig changed the title doc: Remove breaking change tags doc: remove breaking change tags Aug 1, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2023

📃 DOCS PREVIEWhttps://logstash_15231.docs-preview.app.elstc.co/diff

Copy link
Contributor

@karenzone karenzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this cleanup while the changes are still fresh.
Left suggestion inline. Otherwise, LGTM.

docs/static/breaking-changes.asciidoc Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2023

📃 DOCS PREVIEWhttps://logstash_15231.docs-preview.app.elstc.co/diff

@jrodewig jrodewig merged commit d196496 into elastic:main Aug 1, 2023
@jrodewig jrodewig deleted the jrodewig/remove-breaking-change-tags branch August 1, 2023 23:04
@jrodewig
Copy link
Contributor Author

jrodewig commented Aug 1, 2023

@logstashmachine backport 8.9

@jrodewig
Copy link
Contributor Author

jrodewig commented Aug 1, 2023

💚 All backports created successfully

Status Branch Result
8.9

Questions ?

Please refer to the Backport tool documentation

jrodewig added a commit that referenced this pull request Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants