-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert 'ExitOnOutOfMemoryError' setting because it requires minimum Java 8u92 #8254
Comments
Elasticsearch has a custom thread exception handler that basically implements exit-on-oom without the need of the 8u92 ExitOnOutOfMemoryError flag (and does a bit more, it terminates on any Error) elastic/elasticsearch#19272 |
Patch that needs to be reverted: #8138 |
@jordansissel - Wont the flag just be ignored in older versions ? |
@jakelandis An unrecognized VM option like that will prevent the VM from starting. |
Thanks jake! I only noticed this problem because I had Java 8u45 on my
workstation and master was failing to start because of it.
…On Fri, Sep 15, 2017 at 6:57 AM Jake Landis ***@***.***> wrote:
Setting removed: #8268 <#8268>
Branch Commits
6.x 5d35a8f
<5d35a8f>
master 70dd05d
<70dd05d>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#8254 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAIC6pLC6LwGe8NwPD9IdBn4I9abPUznks5sioI3gaJpZM4PX3Pw>
.
|
our support matrix targets Java 8u60, but 'ExitOnOutOfMemoryError' was only added in Java 8u92.
http://www.oracle.com/technetwork/java/javase/8u92-relnotes-2949471.html
We need to revert ExitOnOutOfMemoryError as long as we don't require 8u92 or higher.
The text was updated successfully, but these errors were encountered: