Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert 'ExitOnOutOfMemoryError' setting because it requires minimum Java 8u92 #8254

Closed
jordansissel opened this issue Sep 14, 2017 · 6 comments

Comments

@jordansissel
Copy link
Contributor

our support matrix targets Java 8u60, but 'ExitOnOutOfMemoryError' was only added in Java 8u92.

http://www.oracle.com/technetwork/java/javase/8u92-relnotes-2949471.html

We need to revert ExitOnOutOfMemoryError as long as we don't require 8u92 or higher.

@jordansissel jordansissel changed the title Revert 'ExitOnOutOfMemoryError' setting Revert 'ExitOnOutOfMemoryError' setting *or* require Java >= 8u92 Sep 14, 2017
@jordansissel
Copy link
Contributor Author

Elasticsearch has a custom thread exception handler that basically implements exit-on-oom without the need of the 8u92 ExitOnOutOfMemoryError flag (and does a bit more, it terminates on any Error) elastic/elasticsearch#19272

@jordansissel jordansissel changed the title Revert 'ExitOnOutOfMemoryError' setting *or* require Java >= 8u92 Revert 'ExitOnOutOfMemoryError' setting because it requires minimum Java 8u92 Sep 14, 2017
@jordansissel
Copy link
Contributor Author

jordansissel commented Sep 14, 2017

Patch that needs to be reverted: #8138

@jakelandis
Copy link
Contributor

@jordansissel - Wont the flag just be ignored in older versions ?

@jasontedor
Copy link
Member

@jakelandis An unrecognized VM option like that will prevent the VM from starting.

@jakelandis
Copy link
Contributor

Setting removed: #8268

Branch Commits
6.x 5d35a8f
master 70dd05d

@jordansissel
Copy link
Contributor Author

jordansissel commented Sep 15, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants