Fixing the offline plugin installation workflow

[acchen97]

Update: please see #6393 for the new offline plugin proposal

There are various bugs around the overall offline plugin install/update/uninstall workflow. This meta ticket is to collate and track these issues.

• Offline install or update (with --local) still tries to connect to Rubygems Clarify offline plugin instructions from plugin command #4651 Offline plugins still not working with logstash 5.0.0 #6229
• Offline update --local (update all) doesn’t give user feedback for all plugins updated Clarify offline plugin instructions from plugin command #4651
• Uninstall command tries to connect to Rubygems ./plugin uninstall - broken for offline uninstall #4522
• Offline plugin install with --no-verify still connects to Rubygems Offline plugin install with --no-verify still tries to reach https://rubygems.com #5721 ./plugin install --local --no-verify still connects to the internet during offline install #4521
• Plugins installed locally cannot be packaged for offline installation [offline installation] plugins installed locally can not be packaged for offline installation #4644

[ph]

There is some work that has been done before to improve the situation but it did not get merged or reviewed. #4779

[colinsurprenant]

@ph some reviewing was done on #4779 but problems were found.

... also some ideas in #4787

[ph]

HTTP_PROXY and HTTPS_PROXY aren't correctly used downstream by jar-dependency when it fetches the pom files. see #6044 (comment)

[colinsurprenant]

I suggest we update this issue with the new proposed --prepare-offline workflow that will use @ph's mechanism for generating self-contained plugins file that include all dependencies and is offline installable and which should replace the global pack/unpack stuff.

[acchen97]

Good idea @colinsurprenant; I've linked the original post directly to the issue with the new proposal.

[ph]

Closing this issue since #6404 was merged.

[nikkelj]

I'm not sure you can close this issue yet. At least when I run this on an offline, with both the old pack/unpack, and new prepare offline method, this thing still tries to connect to the internet, and bombs out with
ERROR: Something went wrong when installing XXXXXX, message: Connection reset by peer

I am experiencing this w/ 5.2.

[ph]

Can you open a new issue including what plugin you are trying to pack and what command you are using?

…

On Mon, Feb 6, 2017 at 6:46 PM Jalon ***@***.***> wrote: I'm not sure you can close this issue yet. At least when I run this on an offline, with both the old pack/unpack, and new prepare offline method, this thing still tries to connect to the internet, and bombs out with ERROR: Something went wrong when installing XXXXXX, message: Connection reset by peer I am experiencing this w/ 5.2. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#5906 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAACgESahWX5mYjN8LguzaR9UxoeK0c2ks5rZ7DBgaJpZM4J8PFv> .

[nikkelj]

Sure thing

[nikkelj]

#6647