concurrent-ruby gem pin is not precise enough #4141

jordansissel · 2015-11-05T01:52:44Z

# From a plugin
% bundle exec rspec
RuntimeError: Logstash expects concurrent-ruby version 0.9.1 and version 0.9.2 is installed, please verify this patch: /Users/
jls/.rvm/gems/jruby-1.7.22/gems/logstash-core-2.0.0-java/lib/logstash/patches/silence_concurrent_ruby_warning.rb

The problem is that bundle install fetched 0.9.2 because our dependency on ~> 0.9.1 and our concurrent ruby warning thingy patch barfs if we are using anything but 0.9.1

The text was updated successfully, but these errors were encountered:

jordansissel · 2015-11-05T01:52:53Z

(this only affects master, really)

jordansissel · 2015-11-05T01:55:37Z

I was going to send a patch, but I'm not entirely sure at a glance if we should pin exactly 0.9.1 (in gem dependency) or relax the silence_concurrent_ruby patch to support 0.9.x

jordansissel · 2015-11-05T01:56:12Z

Over to @ph for some insight (based on authorship of b863ace)

ph · 2015-11-05T01:57:20Z

Oh oh :(

ph · 2015-11-05T01:59:23Z

When we merged the shutdown changes the dependency for concurrent-ruby was also changed.

3bdac41#diff-1176bf3d867047e464f26cb769921d70R26

I think concurrent-ruby is really close to release 1.0

ph · 2015-11-05T02:00:44Z

I will review if they changed their warnings.

Russell-IO · 2015-11-05T12:33:14Z

@jordansissel - this affects logstash 2.0.0 & 1.5.5 as far as I can tell.
root@ip-10-12-0-62:/var/log/logstash# /opt/logstash/bin/logstash agent -f /opt/logstash-configuration/green/conf.d/v2/output/apache/
RuntimeError: Logstash expects concurrent-ruby version 0.9.1 and version 0.9.2 is installed, please verify this patch: /opt/logstash/vendor/bundle/jruby/1.9/gems/logstash-core-2.0.0-java/lib/logstash/patches/silence_concurrent_ruby_warning.rb
(root) at /opt/logstash/vendor/bundle/jruby/1.9/gems/logstash-core-2.0.0-java/lib/logstash/patches/silence_concurrent_ruby_warning.rb:53
require at org/jruby/RubyKernel.java:1040
(root) at /opt/logstash/vendor/bundle/jruby/1.9/gems/logstash-core-2.0.0-java/lib/logstash/patches.rb:1
require at org/jruby/RubyKernel.java:1040
(root) at /opt/logstash/vendor/bundle/jruby/1.9/gems/logstash-core-2.0.0-java/lib/logstash/patches.rb:6
require at org/jruby/RubyKernel.java:1040
(root) at /opt/logstash/vendor/bundle/jruby/1.9/gems/logstash-core-2.0.0-java/lib/logstash/environment.rb:1
require at org/jruby/RubyKernel.java:1040
(root) at /opt/logstash/lib/bootstrap/environment.rb:48

RuntimeError: Logstash expects concurrent-ruby version 0.9.1 and version 0.9.2 is installed, please verify this patch: /opt/logstash/vendor/bundle/jruby/1.9/gems/logstash-core-1.5.5-java/lib/logstash/patches/silence_concurrent_ruby_warning.rb
(root) at /opt/logstash/vendor/bundle/jruby/1.9/gems/logstash-core-1.5.5-java/lib/logstash/patches/silence_concurrent_ruby_warning.rb:53
require at org/jruby/RubyKernel.java:1040
(root) at /opt/logstash/vendor/bundle/jruby/1.9/gems/logstash-core-1.5.5-java/lib/logstash/patches.rb:1
require at org/jruby/RubyKernel.java:1040
(root) at /opt/logstash/vendor/bundle/jruby/1.9/gems/logstash-core-1.5.5-java/lib/logstash/patches.rb:6
require at org/jruby/RubyKernel.java:1040
(root) at /opt/logstash/vendor/bundle/jruby/1.9/gems/logstash-core-1.5.5-java/lib/logstash/environment.rb:1
require at org/jruby/RubyKernel.java:1040
(root) at /opt/logstash/lib/bootstrap/environment.rb:48

Russell-IO · 2015-11-05T12:38:08Z

issue seems to be in /opt/logstash/vendor/bundle/jruby/1.9/gems/logstash-core-2.0.0-java/lib/logstash/patches/silence_concurrent_ruby_warning.rb - raising an exception ..
Does logstash need this patch with concurrenty-ruby 0.9.2 ?

purbon · 2015-11-05T14:02:16Z

just hit this issue after rebasing #3583 from master.

purbon · 2015-11-05T14:04:31Z

@ph I think, the best for now would be fix the version. We can always update to a new one as soon as they release it.

ph · 2015-11-05T14:16:15Z

@jordansissel I suggest we use 0.9.2 and relax the fix to match 0.9.X.

This warning will go away in future concurrent-ruby version because they have changed their mind and they will keep supporting JDK7 see ruby-concurrency/concurrent-ruby#435

So once 1.0 is released we can drop that patch.

ph · 2015-11-05T14:17:25Z

I also make the patch not applied and not raise anything if the version doesn't match.

purbon · 2015-11-05T14:20:01Z

+1 on fixing this as you proposed. I guess we can move forward and get this done soon. Otherwise all builds are broken for now.

ph · 2015-11-05T14:25:48Z

nevermind the patch isn't need ruby-concurrency/concurrent-ruby#440 this is 0.9.2 release.

warning and they are commiting to support the 1.X release for JDK7 Fixes elastic#4141

purbon · 2015-11-05T14:30:22Z

@ph can we make a PR out of it?

The team behind concurrent ruby will now support JDK 7 in the 1.x release Fixes elastic#4141

The team behind concurrent ruby will now support JDK 7 in the 1.x release Fixes #4141 Fixes #4146

ph · 2015-11-05T15:00:13Z

@Russell-IO did you update the plugins in your installation before getting that error?
What packages are you using (deb/rpm) ?

purbon · 2015-11-06T10:31:55Z

@suyograo @ph we need to release a point release to get this fix upstream, hitting this issue when doing work in the twitter plugin.

skywalker% bundle exec rspec
RuntimeError: Logstash expects concurrent-ruby version 0.9.1 and version 0.9.2 is installed, please verify this patch: /Users/purbon/.rbenv/versions/jruby-1.7.20/lib/ruby/gems/shared/gems/logstash-core-2.0.0-java/lib/logstash/patches/silence_concurrent_ruby_warning.rb
           (root) at /Users/purbon/.rbenv/versions/jruby-1.7.20/lib/ruby/gems/shared/gems/logstash-core-2.0.0-java/lib/logstash/patches/silence_concurrent_ruby_warning.rb:53
          require at org/jruby/RubyKernel.java:1072
           (root) at /Users/purbon/.rbenv/versions/jruby-1.7.20/lib/ruby/gems/shared/gems/logstash-core-2.0.0-java/lib/logstash/patches.rb:1
          require at org/jruby/RubyKernel.java:1072
           (root) at /Users/purbon/.rbenv/versions/jruby-1.7.2

ph · 2015-11-06T13:54:37Z

We will next week, I've release beats with a constraint on 0.9.1 this
should fix the case when people where updating their plugins.

On Fri, Nov 6, 2015 at 5:31 AM, Pere Urbón [email protected] wrote:

@suyograo https://github.com/suyograo @ph https://github.com/ph we
need to release a point release to get this fix upstream, hitting this
issue when doing work in the twitter plugin.

skywalker% bundle exec rspec
RuntimeError: Logstash expects concurrent-ruby version 0.9.1 and version 0.9.2 is installed, please verify this patch: /Users/purbon/.rbenv/versions/jruby-1.7.20/lib/ruby/gems/shared/gems/logstash-core-2.0.0-java/lib/logstash/patches/silence_concurrent_ruby_warning.rb
(root) at /Users/purbon/.rbenv/versions/jruby-1.7.20/lib/ruby/gems/shared/gems/logstash-core-2.0.0-java/lib/logstash/patches/silence_concurrent_ruby_warning.rb:53
require at org/jruby/RubyKernel.java:1072
(root) at /Users/purbon/.rbenv/versions/jruby-1.7.20/lib/ruby/gems/shared/gems/logstash-core-2.0.0-java/lib/logstash/patches.rb:1
require at org/jruby/RubyKernel.java:1072
(root) at /Users/purbon/.rbenv/versions/jruby-1.7.2

—
Reply to this email directly or view it on GitHub
#4141 (comment).

ph
Software Engineer

purbon · 2015-11-06T13:57:37Z

@ph makes sense. I think a lesson to be learn form this, is be careful with open ranges in dependencies, even small ones can cause trouble 👍 thanks man!

driskell · 2015-11-10T12:16:57Z

I'm seeing this happen when plugins are updated on Logstash 2.0.0

If you run bin/plugin update logstash-input-courier for example, it ends up upgrading the concurrent-ruby gem too. Could it because a dependency on logstash-core means when updating a plugin it updates all involved dependencies too?

driskell · 2015-11-10T12:18:29Z

Any advice on how to fix an installation broken by this?

driskell · 2015-11-10T12:53:39Z

I managed to fix it by adding gem "concurrent-ruby", "0.9.1" to the Gemfile and then updating any plugin, such as bin/plugin update logstash-input-tcp. Even if the plugin doesn't update it correctly rolls back the concurrent-ruby gem

ph · 2015-11-10T14:09:23Z

@driskell thanks for following this up, you can can also do bin/plugin install --no-verify which should only update the added dependencies.

The team behind concurrent ruby will now support JDK 7 in the 1.x release Fixes #4141 Fixes #4146

Former-commit-id: 88fe6da

Former-commit-id: 6ae6cf8

jordansissel assigned ph Nov 5, 2015

ph added the v2.1.0 label Nov 5, 2015

ph added a commit to ph/logstash that referenced this issue Nov 5, 2015

This patch isn't needed for 0.9.2 they have removed the deprecation

e0a5fb4

warning and they are commiting to support the 1.X release for JDK7 Fixes elastic#4141

ph added a commit to ph/logstash that referenced this issue Nov 5, 2015

This patch isn't needed for 0.9.2 they have removed the deprecation

a8751c9

warning and they are commiting to support the 1.X release for JDK7 Fixes elastic#4141

ph added a commit to ph/logstash that referenced this issue Nov 5, 2015

Since concurrent-ruby 0.9.2 this patch isnt necessary.

12d118a

The team behind concurrent ruby will now support JDK 7 in the 1.x release Fixes elastic#4141

ph mentioned this issue Nov 5, 2015

Since concurrent-ruby 0.9.2 this patch isnt necessary. #4146

Closed

ph added a commit to ph/logstash that referenced this issue Nov 5, 2015

Since concurrent-ruby 0.9.2 this patch isnt necessary.

d7da974

The team behind concurrent ruby will now support JDK 7 in the 1.x release Fixes elastic#4141

ph mentioned this issue Nov 5, 2015

gemspec doesn't require concurrent-ruby version 0.9.1 logstash-plugins/logstash-input-beats#17

Closed

ph added a commit that referenced this issue Nov 5, 2015

Since concurrent-ruby 0.9.2 this patch isnt necessary.

e842b85

The team behind concurrent ruby will now support JDK 7 in the 1.x release Fixes #4141 Fixes #4146

ph closed this as completed in 972e13d Nov 5, 2015

ph added a commit that referenced this issue Nov 5, 2015

Since concurrent-ruby 0.9.2 this patch isnt necessary.

1b9a0ad

The team behind concurrent ruby will now support JDK 7 in the 1.x release Fixes #4141 Fixes #4146

ph mentioned this issue Nov 5, 2015

Add a daily run on jenkins for the master/2.0/2.1 branch #4148

Open

samcday pushed a commit to samcday/logstash-output-kinesis that referenced this issue Nov 6, 2015

Add workaround for elastic/logstash#4141

88fe6da

samcday pushed a commit to samcday/logstash-output-kinesis that referenced this issue Nov 6, 2015

Add workaround for elastic/logstash#4141

6ae6cf8

driskell mentioned this issue Nov 10, 2015

Possible Logstash 2.0 compatibility issue driskell/log-courier#247

Closed

ph mentioned this issue Nov 11, 2015

Strict dependency on concurrent-ruby 0.9.2 #4174

Closed

ph added a commit that referenced this issue Nov 19, 2015

Since concurrent-ruby 0.9.2 this patch isnt necessary.

300833d

The team behind concurrent ruby will now support JDK 7 in the 1.x release Fixes #4141 Fixes #4146

tuukkamustonen mentioned this issue Nov 20, 2015

Error: no time information in \"\" logstash-plugins/logstash-input-s3#64

Closed

turtlemonvh mentioned this issue Nov 20, 2015

Behavior when output file is deleted while LS is running logstash-plugins/logstash-output-file#20

Closed

purbon mentioned this issue Nov 26, 2015

Users updating plugins in 2.0.0 version, will hit the concurrent ruby issue #4281

Closed

samcday pushed a commit to samcday/logstash-output-kinesis that referenced this issue Sep 2, 2017

Add workaround for elastic/logstash#4141

5e70e74

Former-commit-id: 88fe6da

gregsterin pushed a commit to gregsterin/logstash-output-kinesis that referenced this issue Jan 17, 2018

Add workaround for elastic/logstash#4141

1be9a38

Former-commit-id: 6ae6cf8

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

concurrent-ruby gem pin is not precise enough #4141

concurrent-ruby gem pin is not precise enough #4141

jordansissel commented Nov 5, 2015

jordansissel commented Nov 5, 2015

jordansissel commented Nov 5, 2015

jordansissel commented Nov 5, 2015

ph commented Nov 5, 2015

ph commented Nov 5, 2015

ph commented Nov 5, 2015

Russell-IO commented Nov 5, 2015

Russell-IO commented Nov 5, 2015

purbon commented Nov 5, 2015

purbon commented Nov 5, 2015

ph commented Nov 5, 2015

ph commented Nov 5, 2015

purbon commented Nov 5, 2015

ph commented Nov 5, 2015

purbon commented Nov 5, 2015

ph commented Nov 5, 2015

purbon commented Nov 6, 2015

ph commented Nov 6, 2015

purbon commented Nov 6, 2015

driskell commented Nov 10, 2015

driskell commented Nov 10, 2015

driskell commented Nov 10, 2015

ph commented Nov 10, 2015

concurrent-ruby gem pin is not precise enough #4141

concurrent-ruby gem pin is not precise enough #4141

Comments

jordansissel commented Nov 5, 2015

jordansissel commented Nov 5, 2015

jordansissel commented Nov 5, 2015

jordansissel commented Nov 5, 2015

ph commented Nov 5, 2015

ph commented Nov 5, 2015

ph commented Nov 5, 2015

Russell-IO commented Nov 5, 2015

Russell-IO commented Nov 5, 2015

purbon commented Nov 5, 2015

purbon commented Nov 5, 2015

ph commented Nov 5, 2015

ph commented Nov 5, 2015

purbon commented Nov 5, 2015

ph commented Nov 5, 2015

purbon commented Nov 5, 2015

ph commented Nov 5, 2015

purbon commented Nov 6, 2015

ph commented Nov 6, 2015

purbon commented Nov 6, 2015

driskell commented Nov 10, 2015

driskell commented Nov 10, 2015

driskell commented Nov 10, 2015

ph commented Nov 10, 2015