-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Cases] Add security only tests #99679
Merged
jonathan-buttner
merged 16 commits into
elastic:cases-rbac-poc
from
jonathan-buttner:add-security-only-tests
May 11, 2021
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
a699e63
Starting spaces tests
jonathan-buttner 206756b
Finishing space only tests
jonathan-buttner 1a685ca
Refactoring createCaseWithConnector
jonathan-buttner 5609c46
Fixing spelling
jonathan-buttner d0b8283
Merge branch 'cases-rbac-poc' of github.com:elastic/kibana into add-s…
jonathan-buttner 7184b0c
Addressing PR feedback and creating alert tests
jonathan-buttner 3b3da5c
Fixing mocks
jonathan-buttner e454d81
Starting security only tests
jonathan-buttner 3f8fcd8
Adding remainder security only tests
jonathan-buttner 0610525
Merge branch 'cases-rbac-poc' of github.com:elastic/kibana into add-s…
jonathan-buttner 1e7d243
Using helper objects
jonathan-buttner 8fbd842
Fixing type error for null space
jonathan-buttner d815591
Renaming utility variables
jonathan-buttner c8d2e50
Merge branch 'cases-rbac-poc' of github.com:elastic/kibana into add-s…
jonathan-buttner ef39b40
Merge branch 'cases-rbac-poc' of github.com:elastic/kibana into add-s…
jonathan-buttner 65b81c6
Refactoring users and roles for security only tests
jonathan-buttner File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -180,7 +180,7 @@ export default ({ getService }: FtrProviderContext): void => { | |
); | ||
|
||
await deleteCases({ | ||
supertest, | ||
supertest: supertestWithoutAuth, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nice catch! |
||
caseIDs: [postedCase.id], | ||
expectedHttpCode: 204, | ||
auth: { user: secOnly, space: 'space1' }, | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License | ||
* 2.0; you may not use this file except in compliance with the Elastic License | ||
* 2.0. | ||
*/ | ||
|
||
import { createTestConfig } from '../common/config'; | ||
|
||
// eslint-disable-next-line import/no-default-export | ||
export default createTestConfig('security_only', { | ||
disabledPlugins: ['spaces'], | ||
license: 'trial', | ||
ssl: true, | ||
testFiles: [require.resolve('./tests/trial')], | ||
}); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cnasikas let me know what you think of my changes here. Basically the approach I took was when the spaces plugin is disabled we can pass in
['*']
so each role has access to all spaces (in reality that'll only be thedefault
space because the spaces plugin is disabled). If we don't give each role access to the default space, then the tests won't work because the space they do have access to (e.g.space1
etc) don't exist.