-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Ingest pipelines] add support for registered_domain processor #99643
[Ingest pipelines] add support for registered_domain processor #99643
Conversation
Pinging @elastic/es-ui (Team:Elasticsearch UI) |
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @sabarasaba! 🎉 Great to see support added to the UI for another processor.
Overall, everything worked as expected. I left a few minor comments. I also found one issue related to the default value for the ignore_missing
parameter. I'd like to see this addressed before approving. I went through and checked our other processors using this component (out of curiosity) and found a similar bug for the csv
processor. I opened #99647 to address separately.
Also, would you mind adding a screenshot of what the default description looks like to your PR? I think it might help the docs team when they review the copy.
...cation/components/pipeline_editor/components/processor_form/processors/registered_domain.tsx
Outdated
Show resolved
Hide resolved
...blic/application/components/pipeline_editor/components/shared/map_processor_type_to_form.tsx
Outdated
Show resolved
Hide resolved
...public/application/components/pipeline_editor/__jest__/processors/registered_domain.test.tsx
Outdated
Show resolved
Hide resolved
...cation/components/pipeline_editor/components/processor_form/processors/registered_domain.tsx
Outdated
Show resolved
Hide resolved
@sabarasaba one more thing I forgot to mention 😄 - would you mind adding a release note to the PR description? You can take a look at #86163 as an example. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick turnaround on addressing my feedback!
I believe you'll also need to define a custom serializer
, as the current behavior sets the field to undefined
if it is false
and strips it from the request. Perhaps we can also add a test for this behavior?
You can check out the form lib docs for more info on how the serializer/deserializer behaves.
.../pipeline_editor/components/processor_form/processors/common_fields/ignore_missing_field.tsx
Outdated
Show resolved
Hide resolved
@alisonelizabeth good point! I totally missed that part in the internal implementation of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Verified locally and everything works as expected now. I left a comment about the use of any
, but won't block on it. Great work!
.../pipeline_editor/components/processor_form/processors/common_fields/ignore_missing_field.tsx
Outdated
Show resolved
Hide resolved
...cation/components/pipeline_editor/components/processor_form/processors/registered_domain.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments, but LGTM overall 🎉 Couldn't build/test locally because packages were missing, but updating the branch might resolve that issue.
...blic/application/components/pipeline_editor/components/shared/map_processor_type_to_form.tsx
Outdated
Show resolved
Hide resolved
...blic/application/components/pipeline_editor/components/shared/map_processor_type_to_form.tsx
Outdated
Show resolved
Hide resolved
@elasticmachine merge upstream |
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Module Count
Async chunks
Unknown metric groupsReferences to deprecated APIs
History
To update your PR or re-run it, just comment with: cc @sabarasaba |
…ic#99643) The Ingest Node Pipelines UI added support to configure a registered domain processor. This processor extracts the registered domain, sub-domain and top-level domain from a fully qualified domain name.
… (#100210) The Ingest Node Pipelines UI added support to configure a registered domain processor. This processor extracts the registered domain, sub-domain and top-level domain from a fully qualified domain name.
…ic#99643) The Ingest Node Pipelines UI added support to configure a registered domain processor. This processor extracts the registered domain, sub-domain and top-level domain from a fully qualified domain name.
Fixes: #97465
Release note
The Ingest Node Pipelines UI added support to configure a registered domain processor. This processor extracts the registered domain, sub-domain and top-level domain from a fully qualified domain name.
Default Description
New Processor fields