Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Support trained model aliases #99174

Merged
merged 8 commits into from
May 5, 2021
Merged

[ML] Support trained model aliases #99174

merged 8 commits into from
May 5, 2021

Conversation

darnautov
Copy link
Contributor

@darnautov darnautov commented May 4, 2021 •
edited
Loading

Summary

Resolves #93392

  • Fetches ingest pipelines associated with model's aliases
    image

  • Adds an extra panel to the expandable row to show models metadata
    image

How to test

  1. Create a trained model using API, or use the one created by the DFA job.
  2. Create an alias for this model making an API call in Dev Tool, check API docs how to write a call https://www.elastic.co/guide/en/elasticsearch/reference/master/put-trained-models-aliases.html
  3. Set up a pipeline using the alias you created as a model_id
  4. You should see this pipeline in the expanded row of the model

Checklist

darnautov added 4 commits May 3, 2021 14:48
@darnautov
[ML] use toString to make sure boolean values are rendered
9bc7f49
@darnautov
[ML] extract metadata
cbef121
@darnautov
[ML] retrieve pipelines associated with model alias
3ae56e9
@darnautov
Merge remote-tracking branch 'upstream/master' into ML-93392-support-…
fb67e99 
…aliases

# Conflicts:
#	x-pack/plugins/ml/public/application/data_frame_analytics/pages/analytics_management/components/models_management/expanded_row.tsx
@darnautov darnautov added release_note:enhancement :ml v8.0.0 Feature:Data Frame Analytics ML data frame analytics features v7.14.0 auto-backport Deprecated - use backport:version if exact versions are needed labels May 4, 2021
@darnautov darnautov self-assigned this May 4, 2021
@darnautov darnautov requested a review from a team as a code owner May 4, 2021 09:35
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

peteharverson
peteharverson approved these changes May 4, 2021
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM

alvarezmelissa87
alvarezmelissa87 approved these changes May 4, 2021
View reviewed changes
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM ⚡

@darnautov darnautov requested a review from pheyos May 4, 2021 16:44
@darnautov darnautov enabled auto-merge (squash) May 5, 2021 09:12
pheyos
pheyos approved these changes May 5, 2021
View reviewed changes
Copy link
Member

@pheyos pheyos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional tests LGTM 🎉

@darnautov
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 5.9MB 5.9MB +1.1KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @darnautov

@darnautov darnautov merged commit 5ce926b into elastic:master May 5, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request May 5, 2021
@darnautov @kibanamachine
[ML] Support trained model aliases (elastic#99174)
702c942 
* [ML] use toString to make sure boolean values are rendered

* [ML] extract metadata

* [ML] retrieve pipelines associated with model alias

* [ML] fix ts issues

* [ML] functional tests

* [ML] remove unused models definitions
@kibanamachine kibanamachine mentioned this pull request May 5, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

@darnautov darnautov deleted the ML-93392-support-aliases branch May 5, 2021 11:39
kibanamachine added a commit that referenced this pull request May 5, 2021
@kibanamachine @darnautov
[ML] Support trained model aliases (#99174) (#99320)
2219b1e 
* [ML] use toString to make sure boolean values are rendered

* [ML] extract metadata

* [ML] retrieve pipelines associated with model alias

* [ML] fix ts issues

* [ML] functional tests

* [ML] remove unused models definitions

Co-authored-by: Dima Arnautov <[email protected]>
@peteharverson peteharverson mentioned this pull request Oct 6, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peteharverson peteharverson peteharverson approved these changes

@alvarezmelissa87 alvarezmelissa87 alvarezmelissa87 approved these changes

@pheyos pheyos pheyos approved these changes

Assignees

@darnautov darnautov

Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Data Frame Analytics ML data frame analytics features :ml release_note:enhancement v7.14.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ML] Support trained model aliases
6 participants
@darnautov @elasticmachine @kibanamachine @pheyos @alvarezmelissa87 @peteharverson