Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SECURITY SOLUTION] Fix unmapped field timeline #99130

Merged
merged 5 commits into from
May 4, 2021
Merged

[SECURITY SOLUTION] Fix unmapped field timeline #99130

merged 5 commits into from
May 4, 2021

Conversation

XavierM
Copy link
Contributor

@XavierM XavierM commented May 3, 2021 •
edited
Loading

Summary

Bringing unmapped field in timeline table/details and if the field is not mapped we won't allow filtering/searching on its value.

Checklist

@XavierM XavierM requested a review from a team as a code owner May 3, 2021 21:22
@XavierM XavierM self-assigned this May 3, 2021
@XavierM XavierM added bug Fixes for quality problems that affect the customer experience impact:critical This issue should be addressed immediately due to a critical level of impact on the product. Team:Threat Hunting Security Solution Threat Hunting Team v7.12.2 v7.13.0 labels May 3, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@XavierM XavierM added the release_note:skip Skip the PR/issue when compiling release notes label May 3, 2021
@XavierM XavierM mentioned this pull request May 4, 2021
Closed
This was referenced May 4, 2021
Closed
Closed
@andrew-goldstein andrew-goldstein mentioned this pull request May 4, 2021
Closed
andrew-goldstein
andrew-goldstein approved these changes May 4, 2021
View reviewed changes
Copy link
Contributor

@andrew-goldstein andrew-goldstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix @XavierM, which resolves several open issues 🙏
Desk tested locally
LGTM 🚀

@andrew-goldstein andrew-goldstein added v8.0.0 auto-backport Deprecated - use backport:version if exact versions are needed labels May 4, 2021
@XavierM XavierM enabled auto-merge (squash) May 4, 2021 02:21
@XavierM XavierM added the v7.14.0 label May 4, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 6.6MB 6.6MB +174.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @XavierM

@XavierM XavierM merged commit 8b8d4d8 into elastic:master May 4, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request May 4, 2021
@XavierM @kibanamachine
[SECURITY SOLUTION] Fix unmapped field timeline (elastic#99130)
8c9ee4c 
* add unmapped include_unmapped

* bringing back unmapped field timeline

* add unit test
@kibanamachine kibanamachine mentioned this pull request May 4, 2021
Merged
@kibanamachine
Copy link
Contributor

💔 Backport failed

Status Branch Result
❌ 7.12 Commit could not be cherrypicked due to conflicts
✅ 7.13
❌ 7.x Commit could not be cherrypicked due to conflicts

Successful backport PRs will be merged automatically after passing CI.

To backport manually run:
node scripts/backport --pr 99130

@XavierM XavierM mentioned this pull request May 4, 2021
Merged
XavierM added a commit to XavierM/kibana that referenced this pull request May 4, 2021
@XavierM
[SECURITY SOLUTION] Fix unmapped field timeline (elastic#99130)
37a14ef 
* add unmapped include_unmapped

* bringing back unmapped field timeline

* add unit test
kibanamachine added a commit that referenced this pull request May 4, 2021
@kibanamachine @XavierM
[SECURITY SOLUTION] Fix unmapped field timeline (#99130) (#99155)
5a6bad4 
* add unmapped include_unmapped

* bringing back unmapped field timeline

* add unit test

Co-authored-by: Xavier Mouligneau <[email protected]>
XavierM added a commit that referenced this pull request May 4, 2021
@XavierM
[SECURITY SOLUTION] Fix unmapped field timeline (#99130) (#99156)
7c29393 
* add unmapped include_unmapped

* bringing back unmapped field timeline

* add unit test
XavierM added a commit to XavierM/kibana that referenced this pull request May 4, 2021
@XavierM
[SECURITY SOLUTION] Fix unmapped field timeline (elastic#99130)
7144590 
* add unmapped include_unmapped

* bringing back unmapped field timeline

* add unit test
@XavierM XavierM mentioned this pull request May 4, 2021
Merged
XavierM added a commit that referenced this pull request May 4, 2021
@XavierM
[7.12] [SECURITY SOLUTION] Fix unmapped field timeline (#99130) (#99213)
c487f7f 
* [SECURITY SOLUTION] Fix unmapped field timeline (#99130)

* add unmapped include_unmapped

* bringing back unmapped field timeline

* add unit test

* fix unit test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrew-goldstein andrew-goldstein andrew-goldstein approved these changes

Assignees

@XavierM XavierM

Labels
auto-backport Deprecated - use backport:version if exact versions are needed bug Fixes for quality problems that affect the customer experience impact:critical This issue should be addressed immediately due to a critical level of impact on the product. release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting Security Solution Threat Hunting Team v7.12.2 v7.13.0 v7.14.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@XavierM @elasticmachine @kibanamachine @andrew-goldstein