Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Alerting] Stack alerts feature privilege test #98195

Merged
merged 4 commits into from
Apr 26, 2021
Merged

[Alerting] Stack alerts feature privilege test #98195

merged 4 commits into from
Apr 26, 2021

Conversation

ymao1
Copy link
Contributor

@ymao1 ymao1 commented Apr 23, 2021

Resolves #95242

Summary

Added test to ensure all registered rule types in Stack Alerts plugin are included in the feature privilege.

Checklist

Delete any items that are not applicable to this PR.

@ymao1 ymao1 self-assigned this Apr 23, 2021
@ymao1 ymao1 added Feature:Alerting release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.14.0 v8.0.0 labels Apr 23, 2021
@ymao1 ymao1 marked this pull request as ready for review April 23, 2021 18:41
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

mikecote
mikecote approved these changes Apr 23, 2021
View reviewed changes
Copy link
Contributor

@mikecote mikecote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM!

@ymao1
Copy link
Contributor Author

ymao1 commented Apr 26, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @ymao1

@ymao1 ymao1 added the auto-backport Deprecated - use backport:version if exact versions are needed label Apr 26, 2021
@ymao1 ymao1 merged commit b6e8e7b into elastic:master Apr 26, 2021
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Apr 26, 2021
@ymao1 @kibanamachine
[Alerting] Stack alerts feature privilege test (elastic#98195)
6dcea19 
* Adding test to verify all registered stack alerts are in the feature privilege

* Checking all and read privileges

Co-authored-by: Kibana Machine <[email protected]>
@kibanamachine kibanamachine mentioned this pull request Apr 26, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Apr 26, 2021
@kibanamachine @ymao1
[Alerting] Stack alerts feature privilege test (#98195) (#98365)
5f2d24d 
* Adding test to verify all registered stack alerts are in the feature privilege

* Checking all and read privileges

Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: ymao1 <[email protected]>
@ymao1 ymao1 deleted the alerting/feature-privilege-test branch May 19, 2021 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikecote mikecote mikecote approved these changes

Assignees

@ymao1 ymao1

Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Alerting release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.14.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Alerting] Add test to ensure all stack alerts are part of stack alert feature privilege.
4 participants
@ymao1 @elasticmachine @kibanamachine @mikecote