Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TSVB] Visualization crashes when it is opened from Metrics Ui #98120

Merged
merged 3 commits into from
Apr 26, 2021

Conversation

stratoula
Copy link
Contributor

@stratoula stratoula commented Apr 23, 2021

Summary

Fixes #98091.

If you install the metricbeat data, go to Metrics --> Metrics explorer --> Visualize, the TSVB chart appears as broken.

It seems that the model.palette is not initialized correctly for the Metrics UI. I initialize the value if it is not and it seems that the bug is fixed.

This bug hasn't released yet. It was caused by the integration of the new color service to TSVB #93749

image

@stratoula stratoula added v7.13.0 release_note:skip Skip the PR/issue when compiling release notes Feature:TSVB TSVB (Time Series Visual Builder) v8.0.0 Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Apr 23, 2021
@stratoula stratoula requested a review from alexwizp April 23, 2021 13:22
@stratoula stratoula marked this pull request as ready for review April 23, 2021 13:22
@stratoula stratoula requested a review from a team April 23, 2021 13:22
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@stratoula stratoula requested a review from wylieconlon April 23, 2021 13:23
@stratoula
Copy link
Contributor Author

@elasticmachine merge upstream

@stratoula stratoula changed the title [TSVB] Metrics UI crashes when it is opened from Metrics Ui [TSVB] Visualization crashes when it is opened from Metrics Ui Apr 26, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
runtimeFields 17 - -17

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
visTypeTimeseries 1.6MB 1.6MB +165.0B

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
runtimeFields 2 - -2
Unknown metric groups

API count

id before after diff
runtimeFields 22 - -22

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@alexwizp alexwizp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you

Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in Chrome, works as expected

@stratoula stratoula merged commit eeee32e into elastic:master Apr 26, 2021
stratoula added a commit to stratoula/kibana that referenced this pull request Apr 26, 2021
…ic#98120)

* [TSVB] Metrics UI crashes when it is opened from Metrics Ui

* Fix bug on initialization

Co-authored-by: Kibana Machine <[email protected]>
stratoula added a commit to stratoula/kibana that referenced this pull request Apr 26, 2021
…ic#98120)

* [TSVB] Metrics UI crashes when it is opened from Metrics Ui

* Fix bug on initialization

Co-authored-by: Kibana Machine <[email protected]>
stratoula added a commit that referenced this pull request Apr 26, 2021
… (#98278)

* [TSVB] Metrics UI crashes when it is opened from Metrics Ui

* Fix bug on initialization

Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>
stratoula added a commit that referenced this pull request Apr 26, 2021
… (#98279)

* [TSVB] Metrics UI crashes when it is opened from Metrics Ui

* Fix bug on initialization

Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:TSVB TSVB (Time Series Visual Builder) release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.13.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Metrics UI] Links to open in TSVB cause TSVB to crash
5 participants