Remove libsass as a dependency #9803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylersmalley
force-pushed
the
9764-no-libsass
branch
3 times, most recently
from
2fb223f to
c2b3a6a
Compare
jbudz
reviewed
Jan 9, 2017
libsass is platform specific, therefore we can not ship it as a dependency. Instead, we will commit the compiled CSS for the UI Framework to the repository. This is updated when running `npm run uiFramework:start` which also starts the docs site. Signed-off-by: Tyler Smalley <[email protected]>
tylersmalley
force-pushed
the
9764-no-libsass
branch
from
c2b3a6a to
efb2a5c
Compare
|
jenkins, test it |
|
I'm not very familiar running the ui framework, did hot reloading work before? I have to do full page refreshes now for styles. |
|
Question above, but otherwise this LGTM. Rebasing on master should fix tests. |
added 2 commits
January 9, 2017 15:53
|
@jbudz, pushed a fix for the hot reloading and merged upstream. Hopefully that resolves the tests. |
|
@jbudz @cjcenizal - we're all green. |
cjcenizal
suggested changes
Jan 10, 2017
There was a problem hiding this comment.
Looks good overall. I had one question.
Also, it looks like the UI Framework CSS isn't being run through PostCSS + Autoprefixer any more.
Ideally, we should update the UI Framework task to run the compiled CSS through PostCSS so we can view the UI Framework documentation in various browsers.
If that's too much trouble at the moment, we can also update base_optimizer.js to run all CSS through PostCSS:
const makeStyleLoader = preprocessor => {
let loaders = [
loaderWithSourceMaps('css-loader'),
{
name: 'postcss-loader',
query: {
config: require.resolve('./postcss.config')
}
},
];
if (preprocessor) {
loaders = [
...loaders,
loaderWithSourceMaps(preprocessor)
];
}
return ExtractTextPlugin.extract(makeLoaderString(loaders));
};|
|
||
| grunt.log.error(message); | ||
|
|
||
| reject(); |
There was a problem hiding this comment.
Do we need to return reject() here?
Signed-off-by: Tyler Smalley <[email protected]>
cjcenizal
approved these changes
Jan 10, 2017
|
Thanks for the review @cjcenizal. @jbudz, let me know if the additional changes look good to you. |
jbudz
approved these changes
Jan 10, 2017
tylersmalley
added a commit
to tylersmalley/kibana
that referenced
this pull request
Jan 10, 2017
Remove libsass as a dependency libsass is platform specific, therefore we can not ship it as a dependency. Instead, we will commit the compiled CSS for the UI Framework to the repository. This is updated when running `npm run uiFramework:start` which also starts the docs site. Signed-off-by: Tyler Smalley <[email protected]>
tylersmalley
added a commit
to tylersmalley/kibana
that referenced
this pull request
Jan 10, 2017
Remove libsass as a dependency libsass is platform specific, therefore we can not ship it as a dependency. Instead, we will commit the compiled CSS for the UI Framework to the repository. This is updated when running `npm run uiFramework:start` which also starts the docs site. Signed-off-by: Tyler Smalley <[email protected]>
tylersmalley
added a commit
that referenced
this pull request
Jan 10, 2017
Remove libsass as a dependency libsass is platform specific, therefore we can not ship it as a dependency. Instead, we will commit the compiled CSS for the UI Framework to the repository. This is updated when running `npm run uiFramework:start` which also starts the docs site. Signed-off-by: Tyler Smalley <[email protected]>
tylersmalley
added a commit
that referenced
this pull request
Jan 10, 2017
Remove libsass as a dependency libsass is platform specific, therefore we can not ship it as a dependency. Instead, we will commit the compiled CSS for the UI Framework to the repository. This is updated when running `npm run uiFramework:start` which also starts the docs site. Signed-off-by: Tyler Smalley <[email protected]>
weltenwort
added a commit
to cjcenizal/kibana
that referenced
this pull request
Jan 12, 2017
weltenwort
pushed a commit
to weltenwort/kibana
that referenced
this pull request
Jan 12, 2017
* Move ContextLoadingButtons out of header into Context view. * Add kuiButton--iconText modifier to ContextLoadingButtons. * Use style guide color for highlighted Context Log row. * Add Bar component. Use Bar to surface entry-pagination controls in Context Log. Refactor ContextSizePicker directive to surface a single input without surrounding text. * Use Panel component to present loading feedback and table within Context app. * Remove fading effect from truncated doc table rows, because it doesn't work with highlighted backgrounds. It also looks weird. * Move bar component to match elastic#9803 * Update ui framework css bundle * Move getter/setter into the size-picker * Remove superfluous loading-button styling
This was referenced Nov 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #9764
libsass is platform specific, therefore we can not ship it as a dependency. Instead, we will commit the compiled CSS for the UI Framework to the repository. This is updated when running
npm run uiFramework:startwhich also starts the docs site.