[Cloud plugin] Added README text #97999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuliacech
added
Team:Core
|
Pinging @elastic/kibana-core (Team:Core) |
yuliacech
added
the
release_note:skip
ryankeairns
approved these changes
Apr 22, 2021
afharo
requested changes
Apr 22, 2021
x-pack/plugins/cloud/README.md
Outdated
| @@ -1,3 +1,12 @@ | |||
| # `cloud` plugin | |||
|
|
|||
| The `cloud` plugin adds cloud specific features to Kibana. | |||
| The plugin configures following values: | |||
There was a problem hiding this comment.
NIT: The list below looks like it's the Public setup contract. The Server-side contract is slightly different.
There was a problem hiding this comment.
You're right, @afharo! I haven't thought about the server-side and never used it before, so I added 'client-side' to the text.
Co-authored-by: Alejandro Fernández Haro <[email protected]>
afharo
approved these changes
Apr 22, 2021
There was a problem hiding this comment.
LGTM!
@yuliacech you might need to run node scripts/build_plugin_list_docs and commit the changes to get a green CI :)
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
yuliacech
added a commit
that referenced
this pull request
Apr 26, 2021
* Added README text * Update x-pack/plugins/cloud/README.md Co-authored-by: Alejandro Fernández Haro <[email protected]> * Updated README.md * Updated docs build Co-authored-by: Alejandro Fernández Haro <[email protected]> Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Alejandro Fernández Haro <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Recently, several new values have been added to Cloud plugin #95569. This PR adds information about those values that Cloud plugin now supplies.
I gathered information from #95569 and cloud#77420 and tried to describe the values how I understand them, change suggestions are welcome.