Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Data frame analytics wizard: ensure progress is updated correctly #97889

Merged
merged 1 commit into from
Apr 22, 2021

Conversation

alvarezmelissa87
Copy link
Contributor

Summary

Fixes #90137

Takes into account jobStats when the job has not started yet but has been created
{currentPhase: 1, progress: 0, totalPhases: 8}

Checks the job has started before clearing interval when state is 'stopped'

Checklist

Delete any items that are not applicable to this PR.

@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@alvarezmelissa87
Copy link
Contributor Author

@pheyos - would you be up for confirming the issue is fixed for you as well? I haven't been able to reproduce again with the fix.

@alvarezmelissa87 alvarezmelissa87 requested a review from qn895 April 21, 2021 19:42
@spalger spalger added v7.14.0 and removed v7.13.0 labels Apr 21, 2021
@qn895
Copy link
Member

qn895 commented Apr 21, 2021

Code LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 5.9MB 5.9MB +62.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @alvarezmelissa87

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

Copy link
Member

@pheyos pheyos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and couldn't reproduce the issue anymore with this fix 🎉
LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ML] Data frame analytics wizard sometimes doesn't upgrade progress
7 participants