Revert skips added while triaging ES OOMs #97876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalger
added
Team:Operations
|
Pinging @elastic/kibana-operations (Team:Operations) |
spalger
added
the
auto-backport
jbudz
approved these changes
Apr 21, 2021
spalger
force-pushed
the
unskip-oom-failures
branch
from
bb656fd to
68348e8
Compare
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
jbudz
approved these changes
Apr 22, 2021
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Apr 22, 2021
* Revert "skip flaky suite (elastic#97382)" This reverts commit e321f57. * Revert "skip flaky suite (elastic#97387)" This reverts commit a89b756. * Revert "Skip test to try and stabilize master" (elastic#97378) This reverts commit 194355f. * upload heap dumps when they are created Co-authored-by: spalger <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Apr 22, 2021
* Revert "skip flaky suite (elastic#97382)" This reverts commit e321f57. * Revert "skip flaky suite (elastic#97387)" This reverts commit a89b756. * Revert "Skip test to try and stabilize master" (elastic#97378) This reverts commit 194355f. * upload heap dumps when they are created Co-authored-by: spalger <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Apr 22, 2021
* Revert "skip flaky suite (#97382)" This reverts commit e321f57. * Revert "skip flaky suite (#97387)" This reverts commit a89b756. * Revert "Skip test to try and stabilize master" (#97378) This reverts commit 194355f. * upload heap dumps when they are created Co-authored-by: spalger <[email protected]> Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Spencer <[email protected]> Co-authored-by: spalger <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Apr 22, 2021
* Revert "skip flaky suite (#97382)" This reverts commit e321f57. * Revert "skip flaky suite (#97387)" This reverts commit a89b756. * Revert "Skip test to try and stabilize master" (#97378) This reverts commit 194355f. * upload heap dumps when they are created Co-authored-by: spalger <[email protected]> Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Spencer <[email protected]> Co-authored-by: spalger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While triaging #97378 we started by skipping tests that seems to be causing the issue. After the first few skips we started to realize that the problem was more systemic and eventually fixed the issue for us with #97813 while we wait for the ES team to figure out the flaw in the GeoIP database downloader that is causing these issues. As such, we need to unskip the tests which were unnecessarily skipped.
Closes #97382
Closes #97387
Closes #97378