Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Build endzone markers #97849

Merged
merged 5 commits into from
Apr 27, 2021
Merged

Conversation

flash1293
Copy link
Contributor

@flash1293 flash1293 commented Apr 21, 2021

Fixes #64544

Adds endzone markers for partial date buckets to the xy chart.

Screenshot 2021-04-22 at 12 25 17

Can be disabled using a setting in the x axis menu

Screenshot 2021-04-22 at 12 25 25

@flash1293 flash1293 added release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 Feature:Lens v7.14.0 auto-backport Deprecated - use backport:version if exact versions are needed labels Apr 21, 2021
@flash1293
Copy link
Contributor Author

@elasticmachine merge upstream

@flash1293 flash1293 marked this pull request as ready for review April 22, 2021 13:55
@flash1293 flash1293 requested a review from a team April 22, 2021 13:55
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

Copy link
Contributor

@wylieconlon wylieconlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good, but I found a weird charts rendering issue in the horizontal chart. I think this is probably a bug in elastic-charts. @markov00 what do you think?

Screen Shot 2021-04-23 at 5 47 15 PM

@flash1293
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
lens 495 496 +1

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
lens 149 150 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 964.6KB 967.8KB +3.1KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
lens 34.3KB 34.5KB +233.0B
Unknown metric groups

API count

id before after diff
lens 160 161 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@flash1293 flash1293 merged commit 6b8c44d into elastic:master Apr 27, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Apr 27, 2021
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Lens release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.14.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Lens] when defined interval is bigger than time range, nothing is being displayed
4 participants