Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data AutoComplete] Allow case insensitve prefix auto complete value suggestions #97797

Conversation

shahzad31
Copy link
Contributor

Summary

As much as i love autocomplete service, it doesn't work where term data is case capital.

For example user_agent.name , where all values are capital case.

image

So if user types c to look out for Chrome, it will never appear in filtered out results.

This Pr adds a case insensitive first letter prefix in the terms include regex patter.

for example if user search for chrome, it will add include: '(chrome|Chrome).*'

and if user search for 'Edge' it will add '(Edge|edge).*'`

This will considerably improve user experience for autocomplete api.

@shahzad31 shahzad31 requested a review from a team as a code owner April 21, 2021 10:55
@shahzad31 shahzad31 self-assigned this Apr 21, 2021
@shahzad31 shahzad31 added release_note:skip Skip the PR/issue when compiling release notes v7.13.0 v8.0.0 labels Apr 21, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @shahzad31

@lizozom
Copy link
Contributor

lizozom commented Apr 21, 2021

@shahzad31 see #92783

@spalger spalger added v7.14.0 and removed v7.13.0 labels Apr 21, 2021
@shahzad31 shahzad31 closed this Apr 22, 2021
@shahzad31 shahzad31 deleted the case-insensitive-prefix-auto-complete branch April 22, 2021 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes v7.14.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants