Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TSVB] Unify styles for YesNo components #97796

Merged
merged 5 commits into from
Apr 26, 2021
Merged

[TSVB] Unify styles for YesNo components #97796

merged 5 commits into from
Apr 26, 2021

Conversation

alexwizp
Copy link
Contributor

@alexwizp alexwizp commented Apr 21, 2021 •
edited
Loading

Summary

This PR unify styles for YesNo component in TSVB. Currently we used that component in a different way and on UI sometimes it looks ugly. e.g.:

image

image

Now all these components have the same spacing. Form looks more accurate

@alexwizp alexwizp self-assigned this Apr 21, 2021
@alexwizp alexwizp added Feature:TSVB TSVB (Time Series Visual Builder) release_note:skip Skip the PR/issue when compiling release notes v7.13.0 v8.0.0 Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Apr 21, 2021
@alexwizp
Copy link
Contributor Author

@elasticmachine merge upstream

VladLasitsa
VladLasitsa approved these changes Apr 21, 2021
View reviewed changes
Copy link
Contributor

@VladLasitsa VladLasitsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexwizp alexwizp marked this pull request as ready for review April 21, 2021 14:58
@alexwizp alexwizp requested a review from a team April 21, 2021 14:58
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@spalger spalger added v7.14.0 and removed v7.13.0 labels Apr 21, 2021
@alexwizp
Copy link
Contributor Author

@elasticmachine merge upstream

@timroes
Copy link
Contributor

timroes commented Apr 22, 2021

@elasticmachine run elasticsearch-ci/docs

@stratoula
Copy link
Contributor

@elasticmachine merge upstream

stratoula
stratoula approved these changes Apr 23, 2021
View reviewed changes
Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems fine @alexwizp, thank you for this 👨‍🎨

@alexwizp
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
visTypeTimeseries 1.6MB 1.6MB -3.0KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @alexwizp

@timroes
Copy link
Contributor

timroes commented Apr 26, 2021

@elasticmachine run elasticsearch-ci/docs

@alexwizp alexwizp merged commit 23e7b7f into elastic:master Apr 26, 2021
@alexwizp alexwizp mentioned this pull request Apr 26, 2021
Merged
alexwizp added a commit to alexwizp/kibana that referenced this pull request Apr 26, 2021
@alexwizp @kibanamachine
[TSVB] Unify styles for YesNo components (elastic#97796)
20b19c3 
Co-authored-by: Kibana Machine <[email protected]>
@alexwizp alexwizp mentioned this pull request Apr 26, 2021
Merged
alexwizp added a commit to alexwizp/kibana that referenced this pull request Apr 26, 2021
@alexwizp @kibanamachine
[TSVB] Unify styles for YesNo components (elastic#97796)
af0373f 
Co-authored-by: Kibana Machine <[email protected]>
alexwizp added a commit that referenced this pull request Apr 26, 2021
@alexwizp @kibanamachine
[TSVB] Unify styles for YesNo components (#97796) (#98272)
ff0880d 
Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>
alexwizp added a commit that referenced this pull request Apr 26, 2021
@alexwizp @kibanamachine
[TSVB] Unify styles for YesNo components (#97796) (#98271)
9777763 
Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>
@alexwizp alexwizp mentioned this pull request Apr 28, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stratoula stratoula stratoula approved these changes

@VladLasitsa VladLasitsa VladLasitsa approved these changes

Assignees

@alexwizp alexwizp

Labels
Feature:TSVB TSVB (Time Series Visual Builder) release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.13.0 v7.14.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@alexwizp @elasticmachine @timroes @stratoula @kibanamachine @VladLasitsa @spalger