[Security Solution] Updates Beats fields metadata #97719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rylnd
added
release_note:enhancement
v8.0.0
Team:Threat Hunting
|
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
XavierM
reviewed
Apr 21, 2021
XavierM
reviewed
Apr 21, 2021
| @@ -221,7 +218,7 @@ async function main() { | |||
| * 2.0. | |||
| */ | |||
|
|
|||
| import { BeatFields } from '../../../common/search_strategy/security_solution/beat_fields'; | |||
| import { BeatFields } from '../../../common/search_strategy/index_fields'; | |||
I simply neglected to commit this change previously
|
@elasticmachine merge upstream |
The fields under test here had a minor grammatical change.
|
Retargeting this for 7.13 for the following reasons:
TL;DR low risk, high reward. |
XavierM
approved these changes
May 4, 2021
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @rylnd |
rylnd
added
the
auto-backport
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
May 4, 2021
* Make script dynamic on our BEATS_VERSION constant * Update hardcoded file path in script * Update fields with 7.12.0 beats * Update BEATS_VERSION to reflect what's been captured thus far I simply neglected to commit this change previously * Update unit test implicitly testing field descriptions The fields under test here had a minor grammatical change. Co-authored-by: Kibana Machine <[email protected]>
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
May 4, 2021
* Make script dynamic on our BEATS_VERSION constant * Update hardcoded file path in script * Update fields with 7.12.0 beats * Update BEATS_VERSION to reflect what's been captured thus far I simply neglected to commit this change previously * Update unit test implicitly testing field descriptions The fields under test here had a minor grammatical change. Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Ryland Herrick <[email protected]>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The intention here is to update these fields with 7.13.0 beats metadata, prior to the corresponding kibana release. It appears that these metadata have not been updated since September, at which time the metadata was pulled from the 7.9.0 beats and released in 7.10 (#77192). Similarly here, since 7.13.0 beats have not yet been released, the metadata contained in this PR was pulled from 7.12.0 beats.
For maintainers