Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [RAC] Populate Observability alerts table with data from alerts indices (#96692) #97399

Merged
merged 1 commit into from
Apr 18, 2021

Conversation

dgieselaar
Copy link
Member

Backports the following commits to 7.x:

…es (elastic#96692)

* Set up Observability rule APIs

* Populate alerts table with data from API

* Move field map types/utils to common

* Format reason/link in alert type

* Format reason/link in alert type

* Fix issues with tsconfigs

* Storybook cleanup for example alerts

* Use `MemoryRouter` in the stories and `useHistory` in the component to get the history
* Replace examples with ones from "real" data
* Use `() => {}` instead of `jest.fn()` in mock registry data

* Store/display evaluations, add active/recovered badge

* Some more story fixes

* Decode rule data with type from owning registry

* Use transaction type/environment in link to app

* Fix type issues

* Fix API tests

* Undo changes in task_runner.ts

* Remove Mutable<> wrappers for field map

* Remove logger.debug calls in alerting es client

* Add API test for recovery of alerts

* Revert changes to src/core/server/http/router

* Use type imports where possible

* Update limits

* Set limit to 100kb

Co-authored-by: Nathan L Smith <[email protected]>
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
apm 1573 1574 +1
observability 316 336 +20
ruleRegistry - 17 +17
total +38

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 4.2MB 4.1MB -54.5KB
observability 422.1KB 447.2KB +25.1KB
total -29.5KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
apm 22.2KB 53.5KB +31.3KB
observability 35.1KB 39.0KB +3.9KB
ruleRegistry - 90.8KB +90.8KB
total +126.0KB
Unknown metric groups

API count

id before after diff
observability 157 176 +19
ruleRegistry 19 52 +33
total +52

API count missing comments

id before after diff
observability 157 176 +19
ruleRegistry 19 52 +33
total +52

API count with any type

id before after diff
ruleRegistry 0 1 +1

Non-exported public API item count

id before after diff
data 75 76 +1
observability 8 7 -1
ruleRegistry 3 4 +1
total +1

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dgieselaar dgieselaar merged commit 0c81ea5 into elastic:7.x Apr 18, 2021
@dgieselaar dgieselaar deleted the backport/7.x/pr-96692 branch April 18, 2021 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants