-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fleet] Add latest package flag and remove force flag #97289
Conversation
Pinging @elastic/fleet (Team:Fleet) |
Pinging @elastic/fleet (Feature:Fleet) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes look good but I'm not sure that latest
is working as expected if an older package version is already installed. I did a local test like this:
- Start kibana with yaml
xpack.fleet.packages:
- name: nginx
version: latest
- name: apache
version: 0.3.4
- Verified that nginx latest and apache 0.3.4 are installed
- Updated kibana yaml to
xpack.fleet.packages:
- name: nginx
version: latest
- name: apache
version: latest
- Observed that apache 0.3.4 is still installed, instead of being upgraded to the latest version. UI shows that an upgrade is available
@jen-huang Updated the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested again locally by specifying apache 0.3.4 -> latest -> back to 0.3.4. Confirmed that the behavior is correct now and the latest version remains installed even when specifying an older version. 🚀
💚 Build SucceededMetrics [docs]Page load bundle
History
To update your PR or re-run it, just comment with: cc @Zacqary |
* [Fleet] Add latest package flag and remove force flag * Fix installing latest package when old package is still installed
Summary
Closes #97138
Preconfiguration can now install a latest version of a package with the
latest
keyword:This also removes the
force
flag for installing outdated versions of packages. Instead, if you specify a particular package version, that version will always be installed unless a later version of the package is already installed.Testing
kibana.dev.yml
to:Ensure that the latest version of nginx is installed, and that version 0.3.4 of apache is installed.
kibana.dev.yml
to read:Wait for the server to restart, and refresh the page. Ensure that the latest version of Azure remains installed, and that 0.2.0 has not been forced to install.