Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Usage Collection/Cloud Provider] Fix isReady bug #97279

Merged
merged 1 commit into from
Apr 15, 2021

Conversation

afharo
Copy link
Member

@afharo afharo commented Apr 15, 2021

Summary

In dev mode I noticed the Telemetry plugin was log.warning that not all collectors were ready after 5 minutes after startup. After debugging, I noticed the cloud provider is causing this issue due to the logic we were running in the isReady method. Since we didn't differentiate between "fetch logic haven't run yet" and "fetch logic run but no cloud provider found", we couldn't tell when it was ready.

This PR attempts to fix that :)

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@afharo afharo added bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes v7.13.0 auto-backport Deprecated - use backport:version if exact versions are needed labels Apr 15, 2021
@afharo afharo requested a review from lukeelmers April 15, 2021 15:56
@afharo afharo requested a review from a team as a code owner April 15, 2021 15:56
@afharo afharo removed the request for review from lukeelmers April 15, 2021 15:57
Copy link
Member

@lukeelmers lukeelmers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, thanks for catching & fixing this!

@afharo afharo enabled auto-merge (squash) April 15, 2021 16:11
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

API count

id before after diff
actions - 113 +113
advancedSettings - 18 +18
alerting - 200 +200
apm - 35 +35
apmOss - 38 +38
banners - 9 +9
beatsManagement - 2 +2
bfetch - 58 +58
canvas - 4 +4
cases - 2 +2
charts - 157 +157
cloud - 19 +19
console - 2 +2
core - 2168 +2168
dashboard - 138 +138
dashboardEnhanced - 51 +51
dashboardMode - 11 +11
data - 3436 +3436
dataEnhanced - 52 +52
devTools - 9 +9
discover - 61 +61
discoverEnhanced - 39 +39
embeddable - 426 +426
embeddableEnhanced - 14 +14
encryptedSavedObjects - 20 +20
enterpriseSearch - 2 +2
esUiShared - 84 +84
eventLog - 70 +70
expressions - 1755 +1755
features - 199 +199
fileUpload - 175 +175
fleet - 1075 +1075
globalSearch - 67 +67
home - 91 +91
indexLifecycleManagement - 5 +5
indexManagement - 162 +162
indexPatternFieldEditor - 29 +29
indexPatternManagement - 46 +46
infra - 14 +14
ingestPipelines - 9 +9
inspector - 97 +97
kibanaLegacy - 92 +92
kibanaReact - 232 +232
kibanaUtils - 465 +465
lens - 160 +160
licenseManagement - 3 +3
licensing - 116 +116
lists - 251 +251
management - 35 +35
maps - 182 +182
mapsEms - 69 +69
ml - 343 +343
monitoring - 9 +9
navigation - 29 +29
newsfeed - 17 +17
observability - 157 +157
osquery - 8 +8
presentationUtil - 69 +69
remoteClusters - 4 +4
reporting - 127 +127
rollup - 20 +20
ruleRegistry - 19 +19
runtimeFields - 22 +22
savedObjects - 173 +173
savedObjectsManagement - 91 +91
savedObjectsTagging - 54 +54
savedObjectsTaggingOss - 81 +81
security - 79 +79
securityOss - 11 +11
securitySolution - 99 +99
share - 66 +66
snapshotRestore - 22 +22
spaces - 82 +82
spacesOss - 64 +64
stackAlerts - 4 +4
taskManager - 41 +41
telemetry - 41 +41
telemetryCollectionManager - 24 +24
telemetryCollectionXpack - 1 +1
telemetryManagementSection - 13 +13
timelines - 6 +6
triggersActionsUi - 221 +221
uiActions - 127 +127
uiActionsEnhanced - 185 +185
uptime - 5 +5
urlForwarding - 14 +14
usageCollection - 53 +53
visTypeTimeseries - 7 +7
visualizations - 212 +212
total +15167

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@afharo afharo merged commit b7067de into elastic:master Apr 15, 2021
@afharo afharo deleted the cloud_provider/isReady-fix branch April 15, 2021 18:04
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Apr 15, 2021
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes v7.13.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants