Fix and unskip integration test suite #97144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crob611
added
Feature:Dashboard
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
|
@elasticmachine merge upstream |
crob611
added
the
impact:high
mshustov
approved these changes
Apr 14, 2021
mshustov
reviewed
Apr 14, 2021
| @@ -230,7 +230,7 @@ export class MonitoringPlugin | |||
| if (this.cluster) { | |||
| this.cluster.close(); | |||
| } | |||
| if (this.licenseService) { | |||
| if (this.licenseService && this.licenseService.stop) { | |||
There was a problem hiding this comment.
It's necessary because the server crashes if it calls stop before start.
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
ThomThomson
approved these changes
Apr 19, 2021
crob611
added
the
auto-backport
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
💔 Backport failed
To backport manually run: |
crob611
pushed a commit
that referenced
this pull request
Apr 19, 2021
Co-authored-by: Kibana Machine <[email protected]> # Conflicts: # src/core/server/saved_objects/migrationsv2/integration_tests/migration_7.7.2_xpack_100k.test.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
For some reason, was waiting until plugin start to register the embeddable factory server side. This was causing migrations to fail on startup.
This moves the registration to happen in setup, and unskips the test suite in question.