[Workplace Search] Add breadcrumbs to Role mappings #97051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottybollinger
added
1
Feature:Plugins
release_note:skip
scottybollinger
added
Feature:Plugins
release_note:skip
cee-chen
approved these changes
Apr 13, 2021
cee-chen
reviewed
Apr 13, 2021
| @@ -42,7 +42,9 @@ export const WorkplaceSearchNav: React.FC<Props> = ({ | |||
| <SideNavLink to={GROUPS_PATH} subNav={groupsSubNav}> | |||
| {NAV.GROUPS} | |||
| </SideNavLink> | |||
| <SideNavLink to={ROLE_MAPPINGS_PATH}>{NAV.ROLE_MAPPINGS}</SideNavLink> | |||
| <SideNavLink shouldShowActiveForSubroutes to={ROLE_MAPPINGS_PATH}> | |||
yakhinvadim
approved these changes
Apr 14, 2021
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Apr 14, 2021
* Update Workplace Search nav to align with App Search * Add constants to shared * [App Search] Use shared constants * [Workplace Search] Add breadcrumbs to Role mappings * Enable shouldShowActiveForSubroutes
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
Apr 14, 2021
* Update Workplace Search nav to align with App Search * Add constants to shared * [App Search] Use shared constants * [Workplace Search] Add breadcrumbs to Role mappings * Enable shouldShowActiveForSubroutes Co-authored-by: Scotty Bollinger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds breadcrumbs to Workplace Search Role mappings. It also moves the constants from App Search to
sharedfor use in both apps.Checklist