Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] Added ability to create API keys (#92610) #96943

Merged
merged 2 commits into from
Apr 13, 2021

Conversation

thomheymann
Copy link
Contributor

Backports the following commits to 7.x:

* Added ability to create API keys

* Remove hard coded colours

* Added unit tests

* Fix linting errors

* Display full base64 encoded API key

* Fix linting errors

* Fix more linting error and unit tests

* Added suggestions from code review

* fix unit tests

* move code editor field into separate component

* fixed tests

* fixed test

* Fixed functional tests

* replaced theme hook with eui import

* Revert to manual theme detection

* added storybook

* Additional unit and functional tests

* Added suggestions from code review

* Remove unused translations

* Updated docs and added detailed error description

* Removed unused messages

* Updated unit test

Co-authored-by: Kibana Machine <[email protected]>
Co-authored-by: Larry Gregory <[email protected]>
# Conflicts:
#	x-pack/plugins/security/public/management/api_keys/api_keys_management_app.test.tsx
#	x-pack/plugins/security/public/management/api_keys/api_keys_management_app.tsx
@thomheymann thomheymann enabled auto-merge (squash) April 13, 2021 11:27
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
security 474 475 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
kibanaReact 311.4KB 312.0KB +650.0B
security 681.6KB 713.4KB +31.7KB
total +32.4KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kibanaReact 115.1KB 117.5KB +2.4KB
security 122.7KB 124.4KB +1.7KB
total +4.1KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@thomheymann thomheymann merged commit f143c7d into elastic:7.x Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants