[plugin-generator] don't generate .eslintrc.js files for internal plugins #96921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalger
added
Team:Operations
|
Pinging @elastic/kibana-operations (Team:Operations) |
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
jbudz
approved these changes
Apr 13, 2021
There was a problem hiding this comment.
~/dev/kibana(pr/96921*) » node scripts/generate_plugin.js test_plugin jon@xps
? Plugin name (use camelCase) test
? Will this plugin be part of the Kibana repository? Yes
? What type of internal plugin would you like to create X-Pack
? Should an UI plugin be generated? Yes
? Should a server plugin be generated? Yes
succ 🎉
Your plugin has been created in x-pack/plugins/test
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
~/dev/kibana(pr/96921*) » cd x-pack/plugins/test
~/dev/kibana/x-pack/plugins/test(pr/96921*) » ls -Rlah jon@xps
.:
total 36K
drwxrwxr-x 5 jon jon 4.0K Apr 13 09:01 .
drwxr-xr-x 68 jon jon 4.0K Apr 13 09:01 ..
drwxrwxr-x 2 jon jon 4.0K Apr 13 09:01 common
-rw-rw-r-- 1 jon jon 182 Dec 21 15:15 .eslintrc.js
-rw-rw-r-- 1 jon jon 104 Dec 21 15:15 .i18nrc.json
-rw-rw-r-- 1 jon jon 164 Dec 21 15:15 kibana.json
drwxrwxr-x 3 jon jon 4.0K Apr 13 09:01 public
-rwxrwxr-x 1 jon jon 203 Dec 21 15:15 README.md
drwxrwxr-x 3 jon jon 4.0K Apr 13 09:01 server
./common:
total 12K
drwxrwxr-x 2 jon jon 4.0K Apr 13 09:01 .
drwxrwxr-x 5 jon jon 4.0K Apr 13 09:01 ..
-rw-rw-r-- 1 jon jon 68 Dec 21 15:15 index.ts
./public:
total 28K
drwxrwxr-x 3 jon jon 4.0K Apr 13 09:01 .
drwxrwxr-x 5 jon jon 4.0K Apr 13 09:01 ..
-rw-rw-r-- 1 jon jon 633 Dec 21 15:15 application.tsx
drwxrwxr-x 2 jon jon 4.0K Apr 13 09:01 components
-rw-rw-r-- 1 jon jon 0 Dec 21 15:15 index.scss
-rw-rw-r-- 1 jon jon 285 Dec 21 15:15 index.ts
-rw-rw-r-- 1 jon jon 1.3K Dec 21 15:15 plugin.ts
-rw-rw-r-- 1 jon jon 350 Dec 21 15:15 types.ts
./public/components:
total 12K
drwxrwxr-x 2 jon jon 4.0K Apr 13 09:01 .
drwxrwxr-x 3 jon jon 4.0K Apr 13 09:01 ..
-rw-rw-r-- 1 jon jon 3.7K Dec 21 15:15 app.tsx
./server:
total 24K
drwxrwxr-x 3 jon jon 4.0K Apr 13 09:01 .
drwxrwxr-x 5 jon jon 4.0K Apr 13 09:01 ..
-rw-rw-r-- 1 jon jon 399 Dec 21 15:15 index.ts
-rw-rw-r-- 1 jon jon 769 Dec 21 15:15 plugin.ts
drwxrwxr-x 2 jon jon 4.0K Apr 13 09:01 routes
-rw-rw-r-- 1 jon jon 204 Dec 21 15:15 types.ts
./server/routes:
total 12K
drwxrwxr-x 2 jon jon 4.0K Apr 13 09:01 .
drwxrwxr-x 3 jon jon 4.0K Apr 13 09:01 ..
-rw-rw-r-- 1 jon jon 353 Dec 21 15:15 index.ts
|
@jbudz thanks for running the generator but it still created a |
kqualters-elastic
approved these changes
Apr 13, 2021
|
Apologies, I misread the top comment and thought we were getting nested .eslintrc's. Re-ran bootstrap, LGTM (again). |
spalger
added
the
auto-backport
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Apr 13, 2021
…gins (elastic#96921) Co-authored-by: spalger <[email protected]>
💔 Backport failed
Successful backport PRs will be merged automatically after passing CI. To backport manually run: |
This was referenced Apr 13, 2021
Merged
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Apr 13, 2021
…gins (elastic#96921) Co-authored-by: spalger <[email protected]> # Conflicts: # x-pack/plugins/timelines/common/index.ts # x-pack/plugins/timelines/public/components/index.tsx # x-pack/plugins/timelines/public/index.ts # x-pack/plugins/timelines/public/plugin.ts # x-pack/plugins/timelines/public/types.ts # x-pack/plugins/timelines/server/config.ts # x-pack/plugins/timelines/server/index.ts # x-pack/plugins/timelines/server/plugin.ts # x-pack/plugins/timelines/server/routes/index.ts # x-pack/plugins/timelines/server/types.ts
kibanamachine
added a commit
that referenced
this pull request
Apr 13, 2021
…gins (#96921) (#96981) Co-authored-by: spalger <[email protected]> Co-authored-by: Spencer <[email protected]> Co-authored-by: spalger <[email protected]>
spalger
pushed a commit
that referenced
this pull request
Apr 13, 2021
…gins (#96921) (#96983) Co-authored-by: spalger <[email protected]> # Conflicts: # x-pack/plugins/timelines/common/index.ts # x-pack/plugins/timelines/public/components/index.tsx # x-pack/plugins/timelines/public/index.ts # x-pack/plugins/timelines/public/plugin.ts # x-pack/plugins/timelines/public/types.ts # x-pack/plugins/timelines/server/config.ts # x-pack/plugins/timelines/server/index.ts # x-pack/plugins/timelines/server/plugin.ts # x-pack/plugins/timelines/server/routes/index.ts # x-pack/plugins/timelines/server/types.ts
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
kibanamachine
added
the
backport missing
kibanamachine
removed
the
backport missing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out a bug in the plugin generator lead to .eslintrc.js files being created in all generated plugin directories, including internal plugins, leading to license headers being disabled in these files 🙃
We should be fine with the license text in the license dir, these headers are just to make things more clear, but we should be using them either way!