Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Ensure ROC chart gets loaded correctly #96890

Merged
merged 1 commit into from
Apr 13, 2021
Merged

[ML] Ensure ROC chart gets loaded correctly #96890

merged 1 commit into from
Apr 13, 2021

Conversation

alvarezmelissa87
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 commented Apr 12, 2021 •
edited
Loading

Summary

Fixes #96603

Before:

image

After:

image

Checklist

Delete any items that are not applicable to this PR.

  • Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)

@alvarezmelissa87 alvarezmelissa87 self-assigned this Apr 12, 2021
@alvarezmelissa87 alvarezmelissa87 requested a review from a team as a code owner April 12, 2021 20:33
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@qn895
Copy link
Member

qn895 commented Apr 12, 2021

LGTM 🎉

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 6.0MB 6.0MB +165.0B

History

  • 💔 Build #118994 failed 2a3e8135a52971741adfc5380b6bafe907563186

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @alvarezmelissa87

@peteharverson peteharverson changed the title ensure ROC chart gets loaded correctly [ML] Ensure ROC chart gets loaded correctly Apr 13, 2021
peteharverson
peteharverson approved these changes Apr 13, 2021
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM

walterra
walterra approved these changes Apr 13, 2021
View reviewed changes
Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alvarezmelissa87 alvarezmelissa87 merged commit 3acabf3 into elastic:master Apr 13, 2021
@alvarezmelissa87 alvarezmelissa87 mentioned this pull request Apr 13, 2021
Merged
@alvarezmelissa87 alvarezmelissa87 deleted the ml-dfa-fix-roc-chart branch April 13, 2021 14:15
alvarezmelissa87 added a commit to alvarezmelissa87/kibana that referenced this pull request Apr 13, 2021
@alvarezmelissa87
ensure ROC chart gets loaded correctly (elastic#96890)
0d987dc
alvarezmelissa87 added a commit that referenced this pull request Apr 13, 2021
@alvarezmelissa87
ensure ROC chart gets loaded correctly (#96890) (#96978)
152257d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qn895 qn895 qn895 approved these changes

@peteharverson peteharverson peteharverson approved these changes

@walterra walterra walterra approved these changes

Assignees

@alvarezmelissa87 alvarezmelissa87

Labels
Feature:Data Frame Analytics ML data frame analytics features :ml release_note:fix v7.13.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ML] DFA exploration: ROC chart not showing for Classification jobs with non default results field
6 participants
@alvarezmelissa87 @elasticmachine @qn895 @kibanamachine @walterra @peteharverson