-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Telemetry] Fix Logstash telemetry collection for multi node clusters #96831
Merged
robbavey
merged 1 commit into
elastic:master
from
robbavey:logstash_telemetry_ephemeral
Apr 13, 2021
Merged
[Telemetry] Fix Logstash telemetry collection for multi node clusters #96831
robbavey
merged 1 commit into
elastic:master
from
robbavey:logstash_telemetry_ephemeral
Apr 13, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this fix, each Logstash node was overwriting the collected list of ephemeral ids used to collect pipeline details. This meant that pipeline details were only being collected for the last Logstash node retrieved for each cluster.
💚 Build SucceededMetrics [docs]
To update your PR or re-run it, just comment with: |
robbavey
added
Feature:Telemetry
release_note:skip
Skip the PR/issue when compiling release notes
v7.12.1
v7.13.0
v8.0.0
labels
Apr 12, 2021
robbavey
added
the
auto-backport
Deprecated - use backport:version if exact versions are needed
label
Apr 13, 2021
afharo
approved these changes
Apr 13, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Apr 13, 2021
…elastic#96831) Prior to this fix, each Logstash node was overwriting the collected list of ephemeral ids used to collect pipeline details. This meant that pipeline details were only being collected for the last Logstash node retrieved for each cluster.
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Apr 13, 2021
…elastic#96831) Prior to this fix, each Logstash node was overwriting the collected list of ephemeral ids used to collect pipeline details. This meant that pipeline details were only being collected for the last Logstash node retrieved for each cluster.
kibanamachine
added a commit
that referenced
this pull request
Apr 13, 2021
…#96831) (#96964) Prior to this fix, each Logstash node was overwriting the collected list of ephemeral ids used to collect pipeline details. This meant that pipeline details were only being collected for the last Logstash node retrieved for each cluster. Co-authored-by: Rob Bavey <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Apr 13, 2021
…#96831) (#96963) Prior to this fix, each Logstash node was overwriting the collected list of ephemeral ids used to collect pipeline details. This meant that pipeline details were only being collected for the last Logstash node retrieved for each cluster. Co-authored-by: Rob Bavey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto-backport
Deprecated - use backport:version if exact versions are needed
Feature:Telemetry
release_note:skip
Skip the PR/issue when compiling release notes
v7.12.1
v7.13.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Prior to this fix, each Logstash node was overwriting the collected list of ephemeral ids used to
collect pipeline details. This meant that pipeline details were only being collected for the
last Logstash node retrieved for each cluster.
Checklist
Delete any items that are not applicable to this PR.
For maintainers