Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Telemetry] Fix Logstash telemetry collection for multi node clusters #96831

Merged
merged 1 commit into from
Apr 13, 2021

Conversation

robbavey
Copy link
Member

@robbavey robbavey commented Apr 12, 2021

Summary

Prior to this fix, each Logstash node was overwriting the collected list of ephemeral ids used to
collect pipeline details. This meant that pipeline details were only being collected for the
last Logstash node retrieved for each cluster.

Checklist

Delete any items that are not applicable to this PR.

For maintainers

Prior to this fix, each Logstash node was overwriting the collected list of ephemeral ids used to
collect pipeline details. This meant that pipeline details were only being collected for the
last Logstash node retrieved for each cluster.
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@robbavey robbavey added Feature:Telemetry release_note:skip Skip the PR/issue when compiling release notes v7.12.1 v7.13.0 v8.0.0 labels Apr 12, 2021
@robbavey robbavey requested a review from afharo April 12, 2021 19:12
@robbavey robbavey added the auto-backport Deprecated - use backport:version if exact versions are needed label Apr 13, 2021
Copy link
Member

@afharo afharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@robbavey robbavey merged commit 46179d6 into elastic:master Apr 13, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Apr 13, 2021
…elastic#96831)

Prior to this fix, each Logstash node was overwriting the collected list of ephemeral ids used to
collect pipeline details. This meant that pipeline details were only being collected for the
last Logstash node retrieved for each cluster.
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Apr 13, 2021
…elastic#96831)

Prior to this fix, each Logstash node was overwriting the collected list of ephemeral ids used to
collect pipeline details. This meant that pipeline details were only being collected for the
last Logstash node retrieved for each cluster.
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.12
7.x

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Apr 13, 2021
…#96831) (#96964)

Prior to this fix, each Logstash node was overwriting the collected list of ephemeral ids used to
collect pipeline details. This meant that pipeline details were only being collected for the
last Logstash node retrieved for each cluster.

Co-authored-by: Rob Bavey <[email protected]>
kibanamachine added a commit that referenced this pull request Apr 13, 2021
…#96831) (#96963)

Prior to this fix, each Logstash node was overwriting the collected list of ephemeral ids used to
collect pipeline details. This meant that pipeline details were only being collected for the
last Logstash node retrieved for each cluster.

Co-authored-by: Rob Bavey <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Telemetry release_note:skip Skip the PR/issue when compiling release notes v7.12.1 v7.13.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants