Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Graph] Fix style for disabled fields when focused #96780

Merged
merged 8 commits into from
Apr 19, 2021

Conversation

dej611
Copy link
Contributor

@dej611 dej611 commented Apr 12, 2021

Summary

Fixes #62155

Had to apply different fixes to make it work for all tested browsers (Safari, Chrome, Firefox).

Screenshot 2021-04-12 at 15 11 36

graph_disabled_badge

Old version Note that on `:hover` the `line-through` decoration is replaced by the `underline`:

disabled_field_hover_graphgif

### Checklist

Delete any items that are not applicable to this PR.

For maintainers

@dej611 dej611 added Feature:Graph Graph application feature Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.13.0 auto-backport Deprecated - use backport:version if exact versions are needed labels Apr 12, 2021
@dej611 dej611 requested a review from a team as a code owner April 12, 2021 13:13
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@flash1293
Copy link
Contributor

Not sure whether I would expect the line-through to disappear on hover, but maybe the design team has an opinion here.

@dej611
Copy link
Contributor Author

dej611 commented Apr 13, 2021

@elasticmachine merge upstream

Copy link
Contributor

@ryankeairns ryankeairns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To Joe's point, I do expect the line-through to persist on hover. The main KQL filter bar works in this manner, as well. I couldn't quite decipher how it works over there, but I think we can hang one style on the button and the second on the inner span since both use the text-decoration rule.

@dej611 dej611 requested a review from ryankeairns April 15, 2021 12:27
Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

It would be cool if we could have some indication the disabled badge is hovered, but it's not a blocker IMHO (and also I don't know how it should look like)
Kapture 2021-04-15 at 14 48 07

Copy link
Contributor

@ryankeairns ryankeairns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving this, it's a tricky one to get all the various states.

@dej611
Copy link
Contributor Author

dej611 commented Apr 16, 2021

@elasticmachine merge upstream

@dej611
Copy link
Contributor Author

dej611 commented Apr 19, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
graph 1.1MB 1.1MB +1.8KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dej611 dej611 merged commit 1b02152 into elastic:master Apr 19, 2021
@dej611 dej611 deleted the fix/62155 branch April 19, 2021 13:30
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Apr 19, 2021
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Graph Graph application feature release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.13.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disabled fields in focused state are confusing
5 participants