-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Graph] Fix style for disabled fields when focused #96780
Conversation
Pinging @elastic/kibana-app (Team:KibanaApp) |
Not sure whether I would expect the line-through to disappear on hover, but maybe the design team has an opinion here. |
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To Joe's point, I do expect the line-through to persist on hover. The main KQL filter bar works in this manner, as well. I couldn't quite decipher how it works over there, but I think we can hang one style on the button and the second on the inner span since both use the text-decoration
rule.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for improving this, it's a tricky one to get all the various states.
@elasticmachine merge upstream |
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
Co-authored-by: Kibana Machine <[email protected]>
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Marco Liberati <[email protected]>
Summary
Fixes #62155
Had to apply different fixes to make it work for all tested browsers (Safari, Chrome, Firefox).
Old version
Note that on `:hover` the `line-through` decoration is replaced by the `underline`:Delete any items that are not applicable to this PR.
For maintainers