[ML] Fix check for too many selected buckets in Anomaly Explorer charts #96771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peteharverson
added
review
release_note:fix
:ml
Feature:Anomaly Detection
|
Pinging @elastic/ml-ui (:ml) |
qn895
approved these changes
Apr 12, 2021
|
Tested and LGTM |
walterra
approved these changes
Apr 13, 2021
peteharverson
added a commit
to peteharverson/kibana
that referenced
this pull request
Apr 13, 2021
peteharverson
added a commit
that referenced
this pull request
Apr 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the check used for displaying the 'too many buckets selected' warning on the charts in the Anomaly Explorer.
Edits the check to use the start of the latest bucket selected in the swim lane when comparing against the chart x-axis maximum.
Before (warning icon is incorrectly displayed even though the 6 days worth of points (144 points) plotted in the chart is well below the max allowed (500 points):
After:
Fixes #95166