-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Moving file data vizualizer to its own plugin #96408
Merged
jgowdyelastic
merged 49 commits into
elastic:master
from
jgowdyelastic:moving-file-data-visualizer-UI-to-file-upload-plugin
Apr 20, 2021
Merged
Changes from 44 commits
Commits
Show all changes
49 commits
Select commit
Hold shift + click to select a range
7c367e4
[ML] Moving file data vizualizer to file upload plugin
jgowdyelastic 96900b7
removing maps plug dependency
jgowdyelastic fa9059f
fixing imports
jgowdyelastic d1b4f86
small refactor
jgowdyelastic 8db222b
adding missing endpoints
jgowdyelastic c0e46ad
fixing translations
jgowdyelastic 2f45468
fxing table controls
jgowdyelastic 176c891
Merge branch 'master' into moving-file-data-visualizer-UI-to-file-upl…
kibanamachine 6a3af38
Merge branch 'master' into moving-file-data-visualizer-UI-to-file-upl…
kibanamachine 56e73f5
fixing types and disabling geo point test
jgowdyelastic 4182f02
Merge branch 'master' into moving-file-data-visualizer-UI-to-file-upl…
kibanamachine d874090
actually disabling geo point test
jgowdyelastic d022521
Merge branch 'moving-file-data-visualizer-UI-to-file-upload-plugin' o…
jgowdyelastic e0d2d2f
Merge branch 'master' into moving-file-data-visualizer-UI-to-file-upl…
kibanamachine 0aa4952
making endpoints internal
jgowdyelastic 6842e98
moving UI code to separate plugin
jgowdyelastic dee153b
enabling maps integration
jgowdyelastic 66c6840
cleaning up dependencies
jgowdyelastic 4d98b7d
Merge branch 'master' into moving-file-data-visualizer-UI-to-file-upl…
kibanamachine 21f6ce6
fixing translation ids
jgowdyelastic 63f6d4f
moving analyze file endpoint out of file upload plugin
jgowdyelastic 6dcf262
fixing transtations issues
jgowdyelastic 8c79c8b
refactor for lazy loading of component
jgowdyelastic 33590f3
updating limits
jgowdyelastic 15a5416
updating plugin asciidoc
jgowdyelastic 37bb050
code clean up
jgowdyelastic 3ea16e7
further clean up
jgowdyelastic b1c93af
Merge branch 'master' into moving-file-data-visualizer-UI-to-file-upl…
kibanamachine 05773e2
Merge branch 'master' into moving-file-data-visualizer-UI-to-file-upl…
kibanamachine 3a10c99
adding comment
jgowdyelastic c558cfe
fixing really obvious CI error
jgowdyelastic 8854d2d
removing commented out include
jgowdyelastic b55b95c
reenabling geo point test
jgowdyelastic 6921ee3
fixing incorrectly changed import
jgowdyelastic 92c211e
removing ml from labels and identifiers
jgowdyelastic 1c8123a
renaming function
jgowdyelastic 97480fe
moving analyse file endpoint to file upload plugin
jgowdyelastic ed6c919
reverting import path changes
jgowdyelastic 33906dc
adding esUiShared back in
jgowdyelastic fbf1215
fixing navigation tabs alignment in basic license
jgowdyelastic d584e68
adding key to tab wrapper
jgowdyelastic 1a4eec2
reverting test label
jgowdyelastic 1721143
Merge branch 'master' into moving-file-data-visualizer-UI-to-file-upl…
kibanamachine dd35676
Merge branch 'master' into moving-file-data-visualizer-UI-to-file-upl…
kibanamachine 51cba88
further removal of ml references
jgowdyelastic 0788b3a
Merge branch 'master' into moving-file-data-visualizer-UI-to-file-upl…
kibanamachine f94eb16
removing ml label from more identifiers
jgowdyelastic e36a733
fixing tests
jgowdyelastic ee2f66f
Merge remote-tracking branch 'origin/master' into moving-file-data-vi…
jgowdyelastic File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -106,6 +106,7 @@ pageLoadAssetSize: | |
indexPatternFieldEditor: 90489 | ||
osquery: 107090 | ||
fileUpload: 25664 | ||
fileDataVisualizer: 27530 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Lots of new code, 27kb isn't a ton and I assume that y'all are async importing everything based on the |
||
banners: 17946 | ||
mapsEms: 26072 | ||
timelines: 28613 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License | ||
* 2.0; you may not use this file except in compliance with the Elastic License | ||
* 2.0. | ||
*/ | ||
|
||
export const UI_SETTING_MAX_FILE_SIZE = 'fileUpload:maxFileSize'; | ||
|
||
export const MB = Math.pow(2, 20); | ||
export const MAX_FILE_SIZE = '100MB'; | ||
export const MAX_FILE_SIZE_BYTES = 104857600; // 100MB | ||
|
||
export const ABSOLUTE_MAX_FILE_SIZE_BYTES = 1073741274; // 1GB | ||
export const FILE_SIZE_DISPLAY_FORMAT = '0,0.[0] b'; | ||
|
||
// Value to use in the Elasticsearch index mapping meta data to identify the | ||
// index as having been created by the ML File Data Visualizer. | ||
export const INDEX_META_DATA_CREATED_BY = 'file-data-visualizer'; | ||
|
||
export const JOB_FIELD_TYPES = { | ||
BOOLEAN: 'boolean', | ||
DATE: 'date', | ||
GEO_POINT: 'geo_point', | ||
GEO_SHAPE: 'geo_shape', | ||
IP: 'ip', | ||
KEYWORD: 'keyword', | ||
NUMBER: 'number', | ||
TEXT: 'text', | ||
UNKNOWN: 'unknown', | ||
} as const; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License | ||
* 2.0; you may not use this file except in compliance with the Elastic License | ||
* 2.0. | ||
*/ | ||
|
||
import { JOB_FIELD_TYPES } from './constants'; | ||
|
||
export type InputData = any[]; | ||
|
||
export type JobFieldType = typeof JOB_FIELD_TYPES[keyof typeof JOB_FIELD_TYPES]; | ||
|
||
export interface DataVisualizerTableState { | ||
pageSize: number; | ||
pageIndex: number; | ||
sortField: string; | ||
sortDirection: string; | ||
visibleFieldTypes: string[]; | ||
visibleFieldNames: string[]; | ||
showDistributions: boolean; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License | ||
* 2.0; you may not use this file except in compliance with the Elastic License | ||
* 2.0. | ||
*/ | ||
|
||
module.exports = { | ||
preset: '@kbn/test', | ||
rootDir: '../../..', | ||
roots: ['<rootDir>/x-pack/plugins/file_data_visualizer'], | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
{ | ||
"id": "fileDataVisualizer", | ||
"version": "8.0.0", | ||
"kibanaVersion": "kibana", | ||
"server": true, | ||
"ui": true, | ||
"requiredPlugins": [ | ||
"data", | ||
"usageCollection", | ||
"embeddable", | ||
"share", | ||
"discover", | ||
"fileUpload" | ||
], | ||
"optionalPlugins": [ | ||
"security", | ||
"maps" | ||
], | ||
"requiredBundles": [ | ||
"kibanaReact", | ||
"maps", | ||
"esUiShared" | ||
], | ||
"extraPublicDirs": [ | ||
"common" | ||
] | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License | ||
* 2.0; you may not use this file except in compliance with the Elastic License | ||
* 2.0. | ||
*/ | ||
|
||
import { lazyLoadModules } from '../lazy_load_bundle'; | ||
import { FileDataVisualizer } from '../application'; | ||
|
||
export async function getFileDataVisualizerComponent(): Promise<typeof FileDataVisualizer> { | ||
const modules = await lazyLoadModules(); | ||
return modules.FileDataVisualizer; | ||
} |
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should add the
file_data_visualizer
plugin to the ML section of theCODEOWNERS
file.