[APM] Extract server type utils to package #96349
Conversation
botelastic
bot
added
Team:APM
|
Pinging @elastic/uptime (Team:uptime) |
|
Pinging @elastic/apm-ui (Team:apm) |
dgieselaar
added
release_note:skip
| // It does not allow params for routes without a params codec | ||
| client({ | ||
| endpoint: 'endpoint_without_params', | ||
| // @ts-expect-error Object literal may only specify known properties, and 'params' does not exist in type |
There was a problem hiding this comment.
Good use of @ts-expect-error 👍
| // @ts-expect-error Property 'noParamsForMe' is missing in type | ||
| const invalidType: { | ||
| noParamsForMe: boolean; | ||
| } = res; |
There was a problem hiding this comment.
If you have access to expect you can double this as both a runtime and compile assertion. And I find the intention a little more clear this way
| // @ts-expect-error Property 'noParamsForMe' is missing in type | |
| const invalidType: { | |
| noParamsForMe: boolean; | |
| } = res; | |
| // @ts-expect-error Property 'noParamsForMe' is missing in return type | |
| expect(res.noParamsForMe).toBe(undefined) |
There was a problem hiding this comment.
expect might not be the appropriate tool, but let me see if I can write some other utility function
There was a problem hiding this comment.
what about something like
There was a problem hiding this comment.
An assert generic is pretty cool 👍
|
@shahzad31 I've added a placeholder - I'd like to work with you on integrating it in Uptime and writing the readme together based on that experience. Please ping me next week or after if you have some time for that! |
💚 Build SucceededMetrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
Extracts the tooling we use to create fully typed server routes to a separate package for use in the Observability plugin (and possibly others).
For examples, see https://github.com/dgieselaar/kibana/blob/17a48e34970387689a7d6e618dd54f7e77564e91/packages/kbn-server-route-repository/src/test_types.ts