Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Runtime field editor] Reset validation when type change #96302

Merged
merged 2 commits into from
Apr 7, 2021
Merged

[Runtime field editor] Reset validation when type change #96302

merged 2 commits into from
Apr 7, 2021

Conversation

sebelga
Copy link
Contributor

@sebelga sebelga commented Apr 6, 2021

This PR fixes an issue where the editor did not clear the painless syntax error after changing the field type.

fixes #95505

@sebelga sebelga requested a review from a team as a code owner April 6, 2021 12:47
@sebelga sebelga requested a review from mattkime April 6, 2021 12:48
@sebelga sebelga added Project:RuntimeFields release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v7.13.0 v8.0.0 labels Apr 6, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui (Team:Elasticsearch UI)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
indexPatternFieldEditor 21.0KB 21.2KB +187.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

mattkime
mattkime approved these changes Apr 6, 2021
View reviewed changes
Copy link
Contributor

@mattkime mattkime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good and work well. Thanks!

@sebelga
Copy link
Contributor Author

sebelga commented Apr 7, 2021

Thanks for the review @mattkime !

@sebelga sebelga merged commit 1327bfe into elastic:master Apr 7, 2021
@sebelga sebelga deleted the runtime-field-editor/reset-validation-when-type-change branch April 7, 2021 10:29
@sebelga sebelga mentioned this pull request Apr 7, 2021
Merged
sebelga added a commit that referenced this pull request Apr 7, 2021
@sebelga
[Runtime field editor] Reset validation when type change (#96302) (#9…
ac4e3fe 
…6386)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattkime mattkime mattkime approved these changes

Assignees
No one assigned
Labels
Project:RuntimeFields release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v7.13.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Runtime field editor doesn't reset validation on field type change
4 participants
@sebelga @elasticmachine @kibanamachine @mattkime