[App Search] Added a query performance rating to the Result Settings page #96230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JasonStoltz
added
release_note:skip
cee-chen
reviewed
Apr 5, 2021
...c/applications/app_search/components/result_settings/query_performance/query_performance.tsx
Outdated
Show resolved
Hide resolved
...c/applications/app_search/components/result_settings/query_performance/query_performance.tsx
Outdated
Show resolved
Hide resolved
...c/applications/app_search/components/result_settings/query_performance/query_performance.tsx
Outdated
Show resolved
Hide resolved
...erprise_search/public/applications/app_search/components/result_settings/result_settings.tsx
Outdated
Show resolved
Hide resolved
...c/applications/app_search/components/result_settings/query_performance/query_performance.tsx
Outdated
Show resolved
Hide resolved
cee-chen
reviewed
Apr 6, 2021
| }; | ||
|
|
||
| const getPerformanceRating = (score: number) => { | ||
| switch (true) { |
cee-chen
reviewed
Apr 6, 2021
| const { queryPerformanceScore } = useValues(ResultSettingsLogic); | ||
| const performanceRating = getPerformanceRating(queryPerformanceScore); | ||
| return ( | ||
| <EuiBadge role="region" aria-live="polite" color={badgeColors[performanceRating]}> |
cee-chen
reviewed
Apr 6, 2021
...se_search/public/applications/app_search/components/result_settings/result_settings.test.tsx
Outdated
Show resolved
Hide resolved
cee-chen
reviewed
Apr 6, 2021
...se_search/public/applications/app_search/components/result_settings/result_settings_logic.ts
Show resolved
Hide resolved
cee-chen
reviewed
Apr 6, 2021
...arch/public/applications/app_search/components/result_settings/result_settings_logic.test.ts
Show resolved
Hide resolved
|
@JasonStoltz BTW, it looks like this branch also needs to be merged/rebased against master to fix a merge conflict. |
|
Updated screenshot after merging with master |
💚 Build SucceededMetrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
cee-chen
approved these changes
Apr 7, 2021
kibanamachine
added a commit
that referenced
this pull request
Apr 7, 2021
…page (#96230) (#96449) Co-authored-by: Jason Stoltzfus <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a "Query performance" badge to the Result Settings page.
The "Query performance" shows the current "rating" inside of a colored badge.
The "rating" shown is based on a numeric value that is calculated by summing numeric values based on the various "raw" and "snippet" settings currently selected.
The "score" is calculated as a "selector" in ResultSettingsLogic.
Based on the score, we show:
When the score is less than 6:
When the score is less than 11:
When the score is less than 21:
When the score is anything 21 or over:
Checklist
Delete any items that are not applicable to this PR.
For maintainers