[Actions] Hiding time field selector if no field with date mapping in index in Index Connector flyout #96080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ymao1
commented
Apr 1, 2021
...ctions_ui/public/application/components/builtin_action_types/es_index/es_index_connector.tsx
Outdated
Show resolved
Hide resolved
…ing/index-connector-timefield
ymao1
added
Feature:Actions
release_note:skip
|
Pinging @elastic/kibana-alerting-services (Team:Alerting Services) |
mikecote
approved these changes
Apr 5, 2021
There was a problem hiding this comment.
Change LGTM but there is one scenario where the Time field still displays.
- Select
.kibanaas the index - Check "Define time field for each document"
- Empty the index field
Result: The Time field doesn't hide with the Define time field for each document field. It should?
YulNaumenko
approved these changes
Apr 5, 2021
…ing/index-connector-timefield
Good catch thanks! Fixed in 1f726bb |
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @ymao1 |
ymao1
added
the
auto-backport
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Apr 7, 2021
… index in Index Connector flyout (elastic#96080) * Hiding time field selector if no field with date mapping in index * Fixing types check * Updating tooltip * PR fixes
kibanamachine
added a commit
that referenced
this pull request
Apr 7, 2021
… index in Index Connector flyout (#96080) (#96423) * Hiding time field selector if no field with date mapping in index * Fixing types check * Updating tooltip * PR fixes Co-authored-by: ymao1 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #91695
Summary
Confusing UX when creating an Index Connector where the wording of the tooltip makes it seem like you can add a timestamp field automatically and the time field selector shows nothing if there is not a
datemapped field in the selected index.Updated UX to only show the time field switch & dropdown if the selected index has 1 or more fields mapped as
date. Also updated the tooltip wording.To Verify
datetype mapped fields (I used.kibana)true, the time field selector will appear and you can select a fielddatetype mapped field (or create a new unmapped index)Checklist
Delete any items that are not applicable to this PR.