Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: ✏️ improve UI actions plugin readme #96030

Merged
merged 4 commits into from
Apr 12, 2021
Merged

docs: ✏️ improve UI actions plugin readme #96030

merged 4 commits into from
Apr 12, 2021

Conversation

streamich
Copy link
Contributor

Summary

Improves readme of the UI actions plugin.

@streamich streamich requested a review from a team as a code owner April 1, 2021 10:44
@streamich streamich added Feature:UIActions UI actions. These are client side only, not related to the server side actions.. release_note:skip Skip the PR/issue when compiling release notes review Team:AppServices v7.13.0 v8.0.0 labels Apr 1, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServices)

ppisljar
ppisljar approved these changes Apr 1, 2021
View reviewed changes
Copy link
Member

@ppisljar ppisljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@streamich
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

kibanamachine commented Apr 12, 2021 •
edited
Loading

⏳ Build in-progress, with failures

Failed CI Steps

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@streamich
Copy link
Contributor Author

Merging this as it is only a docs change and there are no failures on CI, but something wrong with kibana-ci reporting.

image

image

@streamich streamich merged commit 7448238 into elastic:master Apr 12, 2021
@streamich streamich mentioned this pull request Apr 12, 2021
Closed
spalger added a commit that referenced this pull request Apr 12, 2021
@spalger
Revert "docs: ✏️ improve UI actions plugin readme (#96030)"
5879d1f 
This reverts commit 7448238.
@spalger
Copy link
Contributor

spalger commented Apr 12, 2021

@streamich merging this broke master. Reverted. Do not merge PRs that are red unless you talk to Operations first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppisljar ppisljar ppisljar approved these changes

Assignees
No one assigned
Labels
Feature:UIActions UI actions. These are client side only, not related to the server side actions.. release_note:skip Skip the PR/issue when compiling release notes reverted review v7.13.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@streamich @elasticmachine @kibanamachine @spalger @ppisljar